From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38516)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vincent@bernat.im>) id 1c8Ni8-0001mx-4O
	for qemu-devel@nongnu.org; Sun, 20 Nov 2016 03:42:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vincent@bernat.im>) id 1c8Ni5-0006V6-0l
	for qemu-devel@nongnu.org; Sun, 20 Nov 2016 03:42:52 -0500
Received: from bart.luffy.cx ([78.47.78.131]:56959)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <vincent@bernat.im>) id 1c8Ni4-0006UC-NI
	for qemu-devel@nongnu.org; Sun, 20 Nov 2016 03:42:48 -0500
From: Vincent Bernat <vincent@bernat.im>
References: <20161118175128.17192-1-samuel.thibault@ens-lyon.org>
	<20161118175128.17192-2-samuel.thibault@ens-lyon.org>
	<6e88c2ca-d43b-27ab-6acb-fa4c958ca976@redhat.com>
	<87twb3dhhf.fsf@luffy.cx> <20161119223003.GD10378@var.home>
Date: Sun, 20 Nov 2016 09:42:46 +0100
In-Reply-To: <20161119223003.GD10378@var.home> (Samuel Thibault's message of
	"Sat, 19 Nov 2016 23:30:03 +0100")
Message-ID: <m3zikufsop.fsf@luffy.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>, Stefan Hajnoczi <stefanha@redhat.com>

 =E2=9D=A6 19 novembre 2016 23:30 +0100, Samuel Thibault <samuel.thibault@g=
nu.org>=C2=A0:

>> > I think you should at least issue a qemu_log_mask(LOG_UNIMP, "...")
>> > call in that case.
>>=20
>> I can do that if needed.
>
> That'd be better indeed. Otherwise people might wonder why things are
> not working. Warning that they have to do the LF -> CR,LF conversion by
> hand is important here.

I have sent an updated patch for that.

Totally unrelated, but on Debian, I have to use -r instead of -Wl,r for
LD_REL. This is explained here:
 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D837574

I don't think the patch has been forwarded to you yet.
--=20
Don't patch bad code - rewrite it.
            - The Elements of Programming Style (Kernighan & Plauger)