* [Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc
@ 2010-05-12 2:28 TeLeMan
2010-05-12 23:05 ` [Qemu-devel] " Juan Quintela
2010-05-22 9:30 ` [Qemu-devel] " Blue Swirl
0 siblings, 2 replies; 3+ messages in thread
From: TeLeMan @ 2010-05-12 2:28 UTC (permalink / raw)
To: qemu-devel
cirrus_post_load() will be executed twice when loading vm states and then the
wrong physical memory will be registered. This issue may lead to crash qemu.
Signed-off-by: TeLeMan <geleman@gmail.com>
---
hw/cirrus_vga.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 9dfe76a..262ba9c 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga
= {
.version_id = 2,
.minimum_version_id = 2,
.minimum_version_id_old = 2,
- .post_load = cirrus_post_load,
.fields = (VMStateField []) {
VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState),
VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0,
--
SUN OF A BEACH
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Qemu-devel] Re: [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc
2010-05-12 2:28 [Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc TeLeMan
@ 2010-05-12 23:05 ` Juan Quintela
2010-05-22 9:30 ` [Qemu-devel] " Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Juan Quintela @ 2010-05-12 23:05 UTC (permalink / raw)
To: TeLeMan; +Cc: qemu-devel
TeLeMan <geleman@gmail.com> wrote:
> cirrus_post_load() will be executed twice when loading vm states and then the
> wrong physical memory will be registered. This issue may lead to crash qemu.
>
> Signed-off-by: TeLeMan <geleman@gmail.com>
Nice catch.
Acked-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc
2010-05-12 2:28 [Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc TeLeMan
2010-05-12 23:05 ` [Qemu-devel] " Juan Quintela
@ 2010-05-22 9:30 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2010-05-22 9:30 UTC (permalink / raw)
To: TeLeMan; +Cc: qemu-devel
Thanks, applied.
On Wed, May 12, 2010 at 2:28 AM, TeLeMan <geleman@gmail.com> wrote:
> cirrus_post_load() will be executed twice when loading vm states and then the
> wrong physical memory will be registered. This issue may lead to crash qemu.
>
> Signed-off-by: TeLeMan <geleman@gmail.com>
> ---
> hw/cirrus_vga.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
> index 9dfe76a..262ba9c 100644
> --- a/hw/cirrus_vga.c
> +++ b/hw/cirrus_vga.c
> @@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga
> = {
> .version_id = 2,
> .minimum_version_id = 2,
> .minimum_version_id_old = 2,
> - .post_load = cirrus_post_load,
> .fields = (VMStateField []) {
> VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState),
> VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0,
> --
> SUN OF A BEACH
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-22 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-12 2:28 [Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc TeLeMan
2010-05-12 23:05 ` [Qemu-devel] " Juan Quintela
2010-05-22 9:30 ` [Qemu-devel] " Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).