[Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state

[Juan Quintela <quintela@redhat.com>]

malc <av1474@comtv.ru> wrote:
> On Tue, 29 Sep 2009, Juan Quintela wrote:
>
>> This simplifies reset_voices, that only takes one argument now.
>> 
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  hw/ac97.c |   42 ++++++++++++++++++++----------------------
>>  1 files changed, 20 insertions(+), 22 deletions(-)
>> 
>> diff --git a/hw/ac97.c b/hw/ac97.c
>> index 610ca60..da6cb2d 100644
>> --- a/hw/ac97.c
>> +++ b/hw/ac97.c
>> @@ -146,6 +146,13 @@ typedef struct AC97BusMasterRegs {
>>      BD bd;
>>  } AC97BusMasterRegs;
>> 
>> +enum {
>> +    PI_INDEX = 0,
>> +    PO_INDEX,
>> +    MC_INDEX,
>> +    LAST_INDEX
>> +};
>
> And this was moved becasue...?

Because I need LAST_INDEX in next part that you quoted.

>> +
>>  typedef struct AC97LinkState {
>>      PCIDevice dev;
>>      QEMUSoundCard card;
>> @@ -162,6 +169,7 @@ typedef struct AC97LinkState {
>>      uint8_t silence[128];
>>      uint32_t base[2];
>>      int bup_flag;
>> +    uint8_t active[LAST_INDEX];
>
> This doesn't belong here, cause the only purpose i can see is to hack
> around defficiencies of the new load/savevm APIs.

That was supposed to be one of the features, not deficiences.  You can't
sent stuff that it is not in the state. It is "by design" that you can't
sent arbitrary variables.

Later, Juan.