From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: "Philippe Mathieu-Daudé " <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Cc: Pierrick Bouvier <pierrick.bouvier@linaro.org>,
Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Subject: Re: [PATCH] rust: pl011: fix device id matching
Date: Thu, 07 Nov 2024 13:09:45 +0000 [thread overview]
Message-ID: <ml0lj.kelxgd4xtqc7@linaro.org> (raw)
In-Reply-To: <2ee0bab1-1baa-4b52-9856-4c1fa4c9ef0e@linaro.org>
On Wed, 06 Nov 2024 22:56, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>On 6/11/24 18:51, Paolo Bonzini wrote:
>> The offset that is compared against 0x3f8..0x400 is not shifted right.
>> Adjust the pattern matching.
>>
>> Cc: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> Cc: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> rust/hw/char/pl011/src/device.rs | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
The device id reporting is still buggy even with this patch. I will send
a proper fix within the day.
next prev parent reply other threads:[~2024-11-07 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 18:51 [PATCH] rust: pl011: fix device id matching Paolo Bonzini
2024-11-06 22:56 ` Philippe Mathieu-Daudé
2024-11-07 13:09 ` Manos Pitsidianakis [this message]
2024-11-07 13:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ml0lj.kelxgd4xtqc7@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).