From: Andreas Schwab <schwab@suse.de>
To: Helge Deller <deller@gmx.de>
Cc: Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
Richard Henderson <richard.henderson@linaro.org>,
"Markus F . X . J . Oberhumer" <notifications@github.com>
Subject: Re: [PATCH 1/6] Revert "linux-user: Make sure initial brk(0) is page-aligned"
Date: Tue, 18 Jul 2023 15:53:22 +0200 [thread overview]
Message-ID: <mvmsf9lcoml.fsf@suse.de> (raw)
In-Reply-To: <20230717213545.142598-2-deller@gmx.de> (Helge Deller's message of "Mon, 17 Jul 2023 23:35:40 +0200")
On Jul 17 2023, Helge Deller wrote:
> This reverts commit d28b3c90cfad1a7e211ae2bce36ecb9071086129.
>
> It just hides the real bug, and even the Linux kernel may
> return page-unaligned addresses.
The initial brk is always page aligned, see binfmt_elf.c:set_brk and the
various arch_randomize_brk implementations.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2023-07-18 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 21:35 [PATCH 0/6] linux-user: brk() syscall fixes and armhf static binary fix Helge Deller
2023-07-17 21:35 ` [PATCH 1/6] Revert "linux-user: Make sure initial brk(0) is page-aligned" Helge Deller
2023-07-18 13:53 ` Andreas Schwab [this message]
2023-07-18 15:47 ` Helge Deller
2023-07-17 21:35 ` [PATCH 2/6] linux-user: Fix qemu brk() to not zero bytes on current page Helge Deller
2023-07-17 21:35 ` [PATCH 3/6] linux-user: Prohibit brk() to to shrink below initial heap address Helge Deller
2023-07-17 21:35 ` [PATCH 4/6] linux-user: Fix signed math overflow in brk() syscall Helge Deller
2023-07-17 22:02 ` Philippe Mathieu-Daudé
2023-07-18 18:18 ` Helge Deller
2023-07-17 21:35 ` [PATCH 5/6] linux-user: Fix strace output for old_mmap Helge Deller
2023-07-17 21:35 ` [PATCH 6/6] linux-user: Fix qemu-arm to run static armhf binaries Helge Deller
2023-07-18 4:19 ` Michael Tokarev
2023-07-17 21:43 ` [PATCH 0/6] linux-user: brk() syscall fixes and armhf static binary fix Philippe Mathieu-Daudé
2023-07-18 3:03 ` Song Gao
2023-07-18 5:42 ` Helge Deller
2023-07-18 7:25 ` Song Gao
2023-07-18 8:30 ` Michael Tokarev
2023-07-19 11:39 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmsf9lcoml.fsf@suse.de \
--to=schwab@suse.de \
--cc=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=notifications@github.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).