qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: Re: linux-user emulation hangs during fork
Date: Wed, 05 Jun 2024 13:10:06 +0200	[thread overview]
Message-ID: <mvmzfrzsl0x.fsf@suse.de> (raw)
In-Reply-To: <mvm5xunu4ye.fsf@suse.de> (Andreas Schwab's message of "Wed, 05 Jun 2024 11:14:17 +0200")

6490d9aa62ef3cbbac2bf584fb0f3e737ab05e44 is the first bad commit
commit 6490d9aa62ef3cbbac2bf584fb0f3e737ab05e44
Author: Richard Henderson <richard.henderson@linaro.org>
Date:   Tue Jan 24 10:10:19 2023 -1000

    linux-user: un-parent OBJECT(cpu) when closing thread
    
    This reinstates commit 52f0c1607671293afcdb2acc2f83e9bccbfa74bb:
    
    While forcing the CPU to unrealize by hand does trigger the clean-up
    code we never fully free resources because refcount never reaches
    zero. This is because QOM automatically added objects without an
    explicit parent to /unattached/, incrementing the refcount.
    
    Instead of manually triggering unrealization just unparent the object
    and let the device machinery deal with that for us.
    
    Resolves: https://gitlab.com/qemu-project/qemu/-/issues/866
    Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
    Reviewed-by: Laurent Vivier <laurent@vivier.eu>
    Message-Id: <20220811151413.3350684-2-alex.bennee@linaro.org>
    
    The original patch tickled a problem in target/arm, and was reverted.
    But that problem is fixed as of commit 3b07a936d3bf.
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
    Message-Id: <20230124201019.3935934-1-richard.henderson@linaro.org>
    Signed-off-by: Laurent Vivier <laurent@vivier.eu>

 linux-user/syscall.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


  reply	other threads:[~2024-06-05 11:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  9:14 linux-user emulation hangs during fork Andreas Schwab
2024-06-05 11:10 ` Andreas Schwab [this message]
2024-06-05 23:14 ` Richard Henderson
2024-06-06  8:27   ` Andreas Schwab
2024-06-06 14:27     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmzfrzsl0x.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).