From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, hch@lst.de
Subject: Re: [Qemu-devel] [RFC PATCH 1/5] block: separate raw images from the file protocol
Date: Wed, 14 Apr 2010 19:36:48 +0100 [thread overview]
Message-ID: <n2ufbd9d3991004141136i7df832f2qf7eb323490db4161@mail.gmail.com> (raw)
In-Reply-To: <1271260214-27443-2-git-send-email-kwolf@redhat.com>
On Wed, Apr 14, 2010 at 4:50 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> +static int raw_set_locked(BlockDriverState *bs, int locked)
> +{
> + RAWState *s = bs->opaque;
> + bdrv_set_locked(s->hd, locked);
> + return 0;
> +}
Not something for this patch, but it's odd that
BlockDriver->bdrv_set_locked() has a return value but global
bdrv_set_locked() doesn't.
Stefan
next prev parent reply other threads:[~2010-04-14 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 15:50 [Qemu-devel] [RFC PATCH 0/5] block: Format/protocol split Kevin Wolf
2010-04-14 15:50 ` [Qemu-devel] [RFC PATCH 1/5] block: separate raw images from the file protocol Kevin Wolf
2010-04-14 18:36 ` Stefan Hajnoczi [this message]
2010-04-14 15:50 ` [Qemu-devel] [RFC PATCH 2/5] block: Split bdrv_open Kevin Wolf
2010-04-14 15:50 ` [Qemu-devel] [RFC PATCH 3/5] block: Avoid forward declaration of bdrv_open_common Kevin Wolf
2010-04-14 15:50 ` [Qemu-devel] [RFC PATCH 4/5] block: Open the underlying image file in generic code Kevin Wolf
2010-04-15 8:48 ` Stefan Hajnoczi
2010-04-14 15:50 ` [Qemu-devel] [RFC PATCH 5/5] block: bdrv_has_zero_init Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=n2ufbd9d3991004141136i7df832f2qf7eb323490db4161@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).