From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O27SH-0004Sd-0V
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 14:36:53 -0400
Received: from [140.186.70.92] (port=46930 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O27SF-0004S0-Kj
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 14:36:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <stefanha@gmail.com>) id 1O27SE-0007y2-AC
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 14:36:51 -0400
Received: from mail-qy0-f183.google.com ([209.85.221.183]:49264)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefanha@gmail.com>) id 1O27SE-0007xw-7k
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 14:36:50 -0400
Received: by qyk13 with SMTP id 13so548762qyk.18
	for <qemu-devel@nongnu.org>; Wed, 14 Apr 2010 11:36:48 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1271260214-27443-2-git-send-email-kwolf@redhat.com>
References: <1271260214-27443-1-git-send-email-kwolf@redhat.com>
	<1271260214-27443-2-git-send-email-kwolf@redhat.com>
Date: Wed, 14 Apr 2010 19:36:48 +0100
Message-ID: <n2ufbd9d3991004141136i7df832f2qf7eb323490db4161@mail.gmail.com>
Subject: Re: [Qemu-devel] [RFC PATCH 1/5] block: separate raw images from the
	file protocol
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, hch@lst.de

On Wed, Apr 14, 2010 at 4:50 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> +static int raw_set_locked(BlockDriverState *bs, int locked)
> +{
> + =A0 =A0RAWState *s =3D bs->opaque;
> + =A0 =A0bdrv_set_locked(s->hd, locked);
> + =A0 =A0return 0;
> +}

Not something for this patch, but it's odd that
BlockDriver->bdrv_set_locked() has a return value but global
bdrv_set_locked() doesn't.

Stefan