From: P J P <ppandit@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: David Gibson <david@gibson.dropbear.id.au>,
Qemu Developers <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>, Moguofang <moguofang@huawei.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: check size before data buffer access
Date: Fri, 26 Oct 2018 15:08:33 +0530 (IST) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1810261507480.8270@xnncv> (raw)
In-Reply-To: <987110b6-9f7d-d82a-69b7-dcd78094c1a6@kaod.org>
+-- On Fri, 26 Oct 2018, Cédric Le Goater wrote --+
| On 10/25/18 8:45 AM, P J P wrote:
| > - While we refactor the routine for better, a patch below seem okay to fix
| > the OOB access issue?
|
| I think it is fine. Please add something like :
|
| qemu_log_mask(LOG_GUEST_ERROR, "ECCB: invalid operation at @0x%08x"
| " size %d\n", opb_addr, sz);
Okay, will do.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
prev parent reply other threads:[~2018-10-26 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 12:19 [Qemu-devel] [PATCH 3/3] ppc/pnv: check size before data buffer access P J P
2018-10-23 15:37 ` David Gibson
2018-10-24 17:03 ` Cédric Le Goater
2018-10-25 6:45 ` P J P
2018-10-26 8:25 ` Cédric Le Goater
2018-10-26 9:38 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1810261507480.8270@xnncv \
--to=ppandit@redhat.com \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=moguofang@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).