From: P J P <ppandit@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Jason Wang <jasowang@redhat.com>, Kira <864786842@qq.com>
Subject: Re: [Qemu-devel] [PATCH] slirp: check data length while emulating ident function
Date: Sun, 13 Jan 2019 23:38:14 +0530 (IST) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1901132317230.18581@xnncv> (raw)
In-Reply-To: <CAJ+F1CLWzB7TGGstPZOVekfQ=pEbeu52mZU3FMnnhr2uUydrrQ@mail.gmail.com>
+-- On Fri, 11 Jan 2019, Marc-André Lureau wrote --+
| > | Check looks correct, it should probably return 1.
| >
| > Function comment says return 1 if 'm' is valid and should be appended via
| > sbappend(). Not sure if unprocessed 'm' should go to sbappend().
|
| If you look at the rest of the function, many similar error cases return 1.
True, not sure if that's right in this case. Nonetheless, I have sent a
revised patch to return 1.
| Ok, could you add it to the commit message ? :)
No, I'm afraid not.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
prev parent reply other threads:[~2019-01-13 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 8:19 [Qemu-devel] [PATCH] slirp: check data length while emulating ident function P J P
2019-01-11 8:51 ` Marc-André Lureau
2019-01-11 9:18 ` P J P
2019-01-11 11:23 ` Marc-André Lureau
2019-01-13 18:08 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1901132317230.18581@xnncv \
--to=ppandit@redhat.com \
--cc=864786842@qq.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).