qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: P J P <ppandit@redhat.com>
To: Sven Schnelle <svens@stackframe.org>
Cc: Li Qiang <pangpei.lq@antfin.com>,
	Jason Wang <jasowang@redhat.com>,
	Qemu Developers <qemu-devel@nongnu.org>,
	Ziming Zhang <ezrakiez@gmail.com>
Subject: Re: [PATCH] net: tulip: check frame size and r/w data length
Date: Mon, 17 Feb 2020 14:50:55 +0530 (IST)	[thread overview]
Message-ID: <nycvar.YSQ.7.76.2002171448510.84833@xnncv> (raw)
In-Reply-To: <20200215092132.GE18657@t470p.stackframe.org>

+-- On Sat, 15 Feb 2020, Sven Schnelle wrote --+
| > +    if (!len1 || !len2 || !s->rx_frame_len) {
| > +        return;
| 
| I haven't tested the patch yet, but would that work if the guest OS passes
| only one buffer to the card? I.e. len1 = x, and len2 = 0 because only
| buffer 1 is available?

  No, it won't. I'll send a revised patch.

Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D



      reply	other threads:[~2020-02-17  9:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11  7:39 [PATCH] net: tulip: check frame size and r/w data length P J P
2020-02-15  9:21 ` Sven Schnelle
2020-02-17  9:20   ` P J P [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YSQ.7.76.2002171448510.84833@xnncv \
    --to=ppandit@redhat.com \
    --cc=ezrakiez@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=pangpei.lq@antfin.com \
    --cc=qemu-devel@nongnu.org \
    --cc=svens@stackframe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).