From: P J P <ppandit@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Stefan Hajnoczi" <stefanha@gmail.com>,
"Li Qiang" <liq3ea@gmail.com>,
"Qemu Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Li Qiang" <pangpei.lq@antfin.com>,
"Sven Schnelle" <svens@stackframe.org>,
"Ziming Zhang" <ezrakiez@gmail.com>
Subject: Re: [PATCH v6 1/2] net: tulip: check frame size and r/w data length
Date: Thu, 26 Mar 2020 10:04:58 +0530 (IST) [thread overview]
Message-ID: <nycvar.YSQ.7.76.2003261004090.55047@xnncv> (raw)
In-Reply-To: <a72da97b-dc0f-99d4-1d59-aba9da2760c9@redhat.com>
+-- On Tue, 24 Mar 2020, Jason Wang wrote --+
| > Why here is '>=' instead of '>'. IIUC the total sending length can reach
| > to sizeof(s->rx_frame). Same in the other place in this patch.
|
| Yes, this need to be fixed.
Sent patch v7. Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D
next prev parent reply other threads:[~2020-03-26 4:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 12:20 [PATCH v6 0/2] net: tulip: add checks to avoid OOB access P J P
2020-03-23 12:20 ` [PATCH v6 1/2] net: tulip: check frame size and r/w data length P J P
2020-03-24 1:29 ` Li Qiang
2020-03-24 5:45 ` Jason Wang
2020-03-24 13:19 ` P J P
2020-03-24 14:54 ` Li Qiang
2020-03-27 2:09 ` Jason Wang
2020-03-27 2:35 ` Li Qiang
2020-03-27 2:53 ` Jason Wang
2020-03-27 3:43 ` Li Qiang
2020-03-26 4:34 ` P J P [this message]
2020-03-23 12:21 ` [PATCH v6 2/2] net: tulip: add .can_receive routine P J P
2020-03-24 2:04 ` Li Qiang
2020-03-24 5:44 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.2003261004090.55047@xnncv \
--to=ppandit@redhat.com \
--cc=ezrakiez@gmail.com \
--cc=jasowang@redhat.com \
--cc=liq3ea@gmail.com \
--cc=pangpei.lq@antfin.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).