From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O9NXQ-000687-G5
	for qemu-devel@nongnu.org; Tue, 04 May 2010 15:12:12 -0400
Received: from [140.186.70.92] (port=33086 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O9NXO-00065U-LW
	for qemu-devel@nongnu.org; Tue, 04 May 2010 15:12:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <igor.v.kovalenko@gmail.com>) id 1O9NXN-00020x-Ae
	for qemu-devel@nongnu.org; Tue, 04 May 2010 15:12:10 -0400
Received: from fg-out-1718.google.com ([72.14.220.159]:17896)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <igor.v.kovalenko@gmail.com>) id 1O9NXN-00020p-4x
	for qemu-devel@nongnu.org; Tue, 04 May 2010 15:12:09 -0400
Received: by fg-out-1718.google.com with SMTP id 19so1306202fgg.10
	for <qemu-devel@nongnu.org>; Tue, 04 May 2010 12:12:08 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <v2lf43fc5581005031329wba9455b0ocfc498c64f9f9acb@mail.gmail.com>
References: <20100503072448.367.7010.stgit@skyserv>
	<20100503072939.367.3130.stgit@skyserv>
	<t2of43fc5581005031306t7434799cl81ed641c7cece8c4@mail.gmail.com>
	<g2mb2fa41d61005031321o91289572ze265c6ae16b35ec2@mail.gmail.com>
	<v2lf43fc5581005031329wba9455b0ocfc498c64f9f9acb@mail.gmail.com>
Date: Tue, 4 May 2010 23:12:07 +0400
Message-ID: <o2pb2fa41d61005041212o8165d47fl70a27517b9627329@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] sparc64: implement global translation
	table entries
From: Igor Kovalenko <igor.v.kovalenko@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On Tue, May 4, 2010 at 12:29 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
> On 5/3/10, Igor Kovalenko <igor.v.kovalenko@gmail.com> wrote:
>> On Tue, May 4, 2010 at 12:06 AM, Blue Swirl <blauwirbel@gmail.com> wrote=
:
>> =A0> On 5/3/10, Igor V. Kovalenko <igor.v.kovalenko@gmail.com> wrote:
>> =A0>> From: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
>> =A0>>
>> =A0>> =A0- match global tte against any context
>> =A0>> =A0- show global tte in MMU dump
>> =A0>>
>> =A0>> =A0Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
>> =A0>
>> =A0> I get this error:
>> =A0> =A0CC =A0 =A0sparc64-softmmu/op_helper.o
>> =A0> cc1: warnings being treated as errors
>> =A0> /src/qemu/target-sparc/op_helper.c: In function 'demap_tlb':
>> =A0> /src/qemu/target-sparc/op_helper.c:129: error: 'context' may be use=
d
>> =A0> uninitialized in this function
>> =A0>
>>
>>
>> My gcc (Gentoo 4.4.3-r2 p1.2) is silent, and looking at the change all
>> =A04 possible cases are handled in switch statement.
>
> I think gcc is not intelligent enough to know that x & 3 has only 4
> possible cases. :-)
>
>> =A0It should initializes context in 3 usable cases and returns from the
>> =A04th which is reserved.
>> =A0How do we fix this issue?
>
> I'd add a default case to one of the cases. Another possibility is to
> initialize the context with 0 and then make one of the cases empty.
>

Added default case, resent this patch only.

--=20
Kind regards,
Igor V. Kovalenko