From: Blue Swirl <blauwirbel@gmail.com>
To: Richard Henderson <rth@twiddle.net>
Cc: agraf@suse.de, qemu-devel@nongnu.org, paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths
Date: Thu, 22 Apr 2010 23:01:43 +0300 [thread overview]
Message-ID: <o2vf43fc5581004221301pec979bds874f2eb81096838d@mail.gmail.com> (raw)
In-Reply-To: <4BD0A994.2090608@twiddle.net>
On 4/22/10, Richard Henderson <rth@twiddle.net> wrote:
> On 04/22/2010 12:38 PM, Blue Swirl wrote:
> > Subpages are used when there are several devices on the same page.
> > It's needed for at least Sparc32.
>
>
> That's fine.
>
>
> > Subwidth (with NULL) is used mainly to indicate that the device does
> > not accept accesses in some access widths. Sparc32 and Sparc64 need
> > this (or some other way to signal bus errors for bad access widths).
>
>
> This is also fine. Although by using NULL all you'd get is a qemu
> null pointer dereference; I suppose this might get caught and
> translated to an cpu exception, but I think it would be preferable
> long-term to be more explicit about this and fill in the entries
> with a function that would explicitly raise the exception.
Perhaps also the bus layer could do something here.
> What this *does* confirm for me is that we don't need to support
> multiple devices at the same address, differentiated by the size
> of the reference. Which is something that the current subpage
> implementation actually supports.
Yes, I also agree it's a bit overkill.
> I'll submit a patch to clean this up.
>
>
> > In fact, many system devices on Sparc64 should only accept 64 bit
> > accesses, but currently we can't enforce this.
>
>
> Cool. This is something that should be fixed by the end result
> of the driver interface re-design that pbrook and I have been
> discussing on IRC.
Interesting. Could you make a summary of the design for the benefit of the list?
next prev parent reply other threads:[~2010-04-22 20:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 20:26 [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths Richard Henderson
2010-04-20 19:54 ` [Qemu-devel] [PATCH 1/2] io: Add CPUIOMemoryOps and use it Richard Henderson
2010-04-20 20:22 ` [Qemu-devel] [PATCH 2/2] io: Add readq/writeq hooks and use them Richard Henderson
2010-04-22 19:38 ` [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths Blue Swirl
2010-04-22 19:55 ` Richard Henderson
2010-04-22 20:01 ` Blue Swirl [this message]
2010-04-22 21:19 ` Richard Henderson
2010-04-23 18:30 ` Blue Swirl
2010-05-28 20:45 ` Paul Brook
2010-04-22 23:47 ` [Qemu-devel] [PATCH] Remove IO_MEM_SUBWIDTH Richard Henderson
2010-04-25 15:06 ` [Qemu-devel] " Blue Swirl
2010-04-26 21:54 ` Artyom Tarasenko
2010-04-27 18:30 ` Richard Henderson
2010-04-28 19:29 ` Artyom Tarasenko
2010-05-06 20:25 ` Artyom Tarasenko
2010-05-07 15:28 ` Blue Swirl
2010-05-07 16:52 ` [Qemu-devel] [PATCH] Fill in unassigned mem read/write callbacks Richard Henderson
2010-05-07 17:02 ` [Qemu-devel] " Blue Swirl
-- strict thread matches above, loose matches on Subject: below --
2010-05-28 21:03 [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=o2vf43fc5581004221301pec979bds874f2eb81096838d@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=agraf@suse.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).