From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZfes-0002oc-Me for qemu-devel@nongnu.org; Fri, 25 Oct 2013 07:34:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZfem-000587-NG for qemu-devel@nongnu.org; Fri, 25 Oct 2013 07:34:26 -0400 References: <526947CA.4020504@gmail.com> <52694821.4040001@gmail.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <52694821.4040001@gmail.com> Date: Fri, 25 Oct 2013 12:34:06 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta Cc: "qemu-ppc@nongnu.org" , QEMU Developers tommusta@gmail.com writes: > This patch adds routines to the softfloat library that are useful for > the PowerPC VSX implementation. The routines are, however, not specific > to PowerPC and are approprriate for softfloat. Is it worth adding some sort of test into make check to defend these softfloat functions against unintentional breakage? It would certainly be worthwhile as soon as multiple arches use these functions as float errors are often subtle and hard to track down. -- Alex Bennée