qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] .gitmodules: use upstream SeaBIOS repo to fix submodule init
Date: Thu, 03 Oct 2013 10:45:25 +0100	[thread overview]
Message-ID: <p1ob76bscq.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_FgLqUbhXx=mfzg22zg_4n2ruJAVdDkHc=cdtDuCAMhw@mail.gmail.com>


peter.maydell@linaro.org writes:

> On 3 October 2013 17:58,  <alex.bennee@linaro.org> wrote:
>> From: Alex Bennée <alex@bennee.com>
>>
>> Currently master is broken as the wanted commit doesn't exist in
>> qemu's mirror of SeaBIOS.
<snip>

> This is wrong. QEMU's submodules should all point to
> git.qemu.org. Among other things our release source
> tarballs pull in the sources and it's a good way to ensure
> it's all consistent and we definitely have version controlled
> copies of the sources we release under our control rather
> than just in an external repo.

Fair enough, I'll drop the patch.

> What should actually happen is that Anthony should fix
> his workflow to ensure that he doesn't commit patches
> which update submodules without also updating the
> qemu.org mirrors of the external repos :-)

Of course once this is merged it will flag up the problem right away
(even sooner if the pull request is a github one ;-)

-- 
Alex Bennée

  reply	other threads:[~2013-10-03  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03  8:58 [Qemu-devel] [PATCH v4 0/0] .travis.yml: basic compile and check recipies and minor fixes alex.bennee
2013-10-03  8:58 ` [Qemu-devel] [PATCH 1/2] .travis.yml: basic compile and check recipes alex.bennee
2013-10-03  8:58 ` [Qemu-devel] [PATCH 2/2] .gitmodules: use upstream SeaBIOS repo to fix submodule init alex.bennee
2013-10-03  9:06   ` Peter Maydell
2013-10-03  9:45     ` Alex Bennée [this message]
2013-10-10  8:51     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p1ob76bscq.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).