From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VRfTP-0003L5-1R
	for qemu-devel@nongnu.org; Thu, 03 Oct 2013 05:45:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VRfTL-00017L-2K
	for qemu-devel@nongnu.org; Thu, 03 Oct 2013 05:45:30 -0400
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:34326 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VRfTK-000179-O8
	for qemu-devel@nongnu.org; Thu, 03 Oct 2013 05:45:26 -0400
References: <1380790737-11495-1-git-send-email-alex.bennee@linaro.org>
	<1380790737-11495-3-git-send-email-alex.bennee@linaro.org>
	<CAFEAcA_FgLqUbhXx=mfzg22zg_4n2ruJAVdDkHc=cdtDuCAMhw@mail.gmail.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <CAFEAcA_FgLqUbhXx=mfzg22zg_4n2ruJAVdDkHc=cdtDuCAMhw@mail.gmail.com>
Date: Thu, 03 Oct 2013 10:45:25 +0100
Message-ID: <p1ob76bscq.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 2/2] .gitmodules: use upstream SeaBIOS repo
	to fix submodule init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>


peter.maydell@linaro.org writes:

> On 3 October 2013 17:58,  <alex.bennee@linaro.org> wrote:
>> From: Alex Bennée <alex@bennee.com>
>>
>> Currently master is broken as the wanted commit doesn't exist in
>> qemu's mirror of SeaBIOS.
<snip>

> This is wrong. QEMU's submodules should all point to
> git.qemu.org. Among other things our release source
> tarballs pull in the sources and it's a good way to ensure
> it's all consistent and we definitely have version controlled
> copies of the sources we release under our control rather
> than just in an external repo.

Fair enough, I'll drop the patch.

> What should actually happen is that Anthony should fix
> his workflow to ensure that he doesn't commit patches
> which update submodules without also updating the
> qemu.org mirrors of the external repos :-)

Of course once this is merged it will flag up the problem right away
(even sooner if the pull request is a github one ;-)

-- 
Alex Bennée