From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50761)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VX9JS-00042x-Mj
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 08:37:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VX9JN-0001Eb-IT
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 08:37:54 -0400
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:35762 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VX9JN-0001EM-Ce
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 08:37:49 -0400
References: <1382096703-31938-1-git-send-email-alex.bennee@linaro.org>
	<1382096703-31938-2-git-send-email-alex.bennee@linaro.org>
	<CAFEAcA_WTRhwg71qBwPsbMD8mtzA=objLk4Kzv4=pqg9AGC1rA@mail.gmail.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <CAFEAcA_WTRhwg71qBwPsbMD8mtzA=objLk4Kzv4=pqg9AGC1rA@mail.gmail.com>
Date: Fri, 18 Oct 2013 13:37:47 +0100
Message-ID: <p1wqlan49w.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by
	emulating dbg region
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>


peter.maydell@linaro.org writes:

> On 18 October 2013 12:45,  <alex.bennee@linaro.org> wrote:
>> +typedef struct {
>> +    SysBusDevice parent_obj;
>> +
>> +    MemoryRegion iomem;
>> +
>> +    uint32_t alpha;
>> +    uint32_t leds;
>> +    uint32_t switches;
>
> These three fields are never used, or did I miss something?

Nope, I obviously had thoughts of tracking the actual LED/Switch state
and never added it in.

>
>> +} IntegratorDebugState;
>
> Looks good otherwise.
>
> thanks
> -- PMM


-- 
Alex Bennée