From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1C3bsm-0005kF-Sd
	for qemu-devel@nongnu.org; Sat, 04 Sep 2004 10:51:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1C3bsk-0005jw-Up
	for qemu-devel@nongnu.org; Sat, 04 Sep 2004 10:51:12 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1C3bsk-0005jm-Qo
	for qemu-devel@nongnu.org; Sat, 04 Sep 2004 10:51:10 -0400
Received: from [80.91.224.249] (helo=main.gmane.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1C3bmz-0005Bc-3I
	for qemu-devel@nongnu.org; Sat, 04 Sep 2004 10:45:13 -0400
Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1C3bmx-0006Mx-00
	for <qemu-devel@nongnu.org>; Sat, 04 Sep 2004 16:45:11 +0200
Received: from amarseille-206-1-28-40.w81-53.abo.wanadoo.fr ([81.53.204.40])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sat, 04 Sep 2004 16:45:11 +0200
Received: from daimon55 by amarseille-206-1-28-40.w81-53.abo.wanadoo.fr with
	local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sat, 04 Sep 2004 16:45:11 +0200
From: Ronald <look@reply.to>
Date: Sat, 04 Sep 2004 16:45:08 +0200
Message-ID: <pan.2004.09.04.14.45.07.440321@reply.to>
References: <20040904000017.GA27986@xi.wantstofly.org>
	<41399DC2.2030404@bellard.org> <4139B2C3.6000203@volny.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: news <news@sea.gmane.org>
Subject: [Qemu-devel] Re: [PATCH] fix interaction with noexecstack
Reply-To: daimon55@free.fr, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Le Sat, 04 Sep 2004 14:19:15 +0200, Filip Navara a écrit :

> Fabrice Bellard wrote:
> 
>> The patch seems OK for me, at least until the instruction cache is
>> dynamically allocated.
> 
> I haven't tried the patch, but there isn't any "mprotect" function on
> Windows so I guess it would break MinGW builds. See the code below. It
> should work, but *I HAVEN'T TESTED IT*:
> 

Tested, need to include <winbase.h> (and <windows.h>).
gcc juste produce a warning with VirtualProtect:
/home/ronald/Prog/Win32/combo/qemu/exec.c: Dans la fonction « page_init »:
/home/ronald/Prog/Win32/combo/qemu/exec.c:155: AVERTISSEMENT: passage de
arg 1 de « VirtualProtect » transforme en pointeur un entier sans
transtypage

aproximative translation: in function page_init passing arg1 of
VirtualProtect is making pointer from integer without a cast.

Note: with **VirtualProtect or *VirtualProtect make is aborting, I have
used VirtualProtect.