From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1G1rbl-0005rj-2t
	for qemu-devel@nongnu.org; Sat, 15 Jul 2006 17:23:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1G1rbj-0005rX-AR
	for qemu-devel@nongnu.org; Sat, 15 Jul 2006 17:23:27 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1G1rbj-0005rU-5L
	for qemu-devel@nongnu.org; Sat, 15 Jul 2006 17:23:27 -0400
Received: from [80.91.229.2] (helo=ciao.gmane.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32)
	(Exim 4.52) id 1G1re1-0000Jn-Eb
	for qemu-devel@nongnu.org; Sat, 15 Jul 2006 17:25:49 -0400
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1G1rba-0005uH-Rp
	for qemu-devel@nongnu.org; Sat, 15 Jul 2006 23:23:18 +0200
Received: from cpe-70-116-9-243.austin.res.rr.com ([70.116.9.243])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sat, 15 Jul 2006 23:23:18 +0200
Received: from anthony by cpe-70-116-9-243.austin.res.rr.com with local
	(Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sat, 15 Jul 2006 23:23:18 +0200
From: Anthony Liguori <anthony@codemonkey.ws>
Date: Sat, 15 Jul 2006 16:18:47 -0500
Message-ID: <pan.2006.07.15.21.18.45.579504@codemonkey.ws>
References: <E1G1UFG-0000WK-3O@savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: news <news@sea.gmane.org>
Subject: [Qemu-devel] Re: qemu monitor.c vl.c
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

I think you want to do check to see if the term buffer is full after
writing the '\r' here right?  Otherwise, I presume it's possible to get a
buffer overflow is '\n' would normally fill the buffer.

Regards,

Anthony Liguori

On Fri, 14 Jul 2006 20:26:42 +0000, Fabrice Bellard wrote:

> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Fabrice Bellard <bellard>	06/07/14 20:26:42
> 
> Modified files:
> 	.              : monitor.c vl.c
> 
> Log message:
> 	generate CRLF instead of LF
> 
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/monitor.c?cvsroot=qemu&r1=1.51&r2=1.52
> http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.199&r2=1.200