From: Stefan Hajnoczi <stefanha@gmail.com>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: ohmura.kei@lab.ntt.co.jp, kvm@vger.kernel.org,
mtosatti@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com
Subject: [Qemu-devel] Re: [RFC PATCH 04/20] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().
Date: Wed, 21 Apr 2010 09:03:43 +0100 [thread overview]
Message-ID: <q2ofbd9d3991004210103tbedf5823v6b9fadca6721f44d@mail.gmail.com> (raw)
In-Reply-To: <1271829445-5328-5-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
On Wed, Apr 21, 2010 at 6:57 AM, Yoshiaki Tamura
<tamura.yoshiaki@lab.ntt.co.jp> wrote:
> @@ -454,6 +458,25 @@ void qemu_fflush(QEMUFile *f)
> }
> }
>
> +void *qemu_realloc_buffer(QEMUFile *f, int size)
> +{
> + f->buf_max_size = size;
> +
> + f->buf = qemu_realloc(f->buf, f->buf_max_size);
> + if (f->buf == NULL) {
> + fprintf(stderr, "qemu file buffer realloc failed\n");
> + exit(1);
> + }
> +
> + return f->buf;
> +}
> +
qemu_realloc() will abort() if there was not enough memory to realloc.
Just like qemu_malloc(), you don't need to check for NULL.
Stefan
next prev parent reply other threads:[~2010-04-21 8:03 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 5:57 [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1 Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 01/20] Modify DIRTY_FLAG value and introduce DIRTY_IDX to use as indexes of bit-based phys_ram_dirty Yoshiaki Tamura
2010-04-22 19:26 ` [Qemu-devel] " Anthony Liguori
2010-04-23 2:09 ` Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 02/20] Introduce cpu_physical_memory_get_dirty_range() Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 03/20] Use cpu_physical_memory_set_dirty_range() to update phys_ram_dirty Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 04/20] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer() Yoshiaki Tamura
2010-04-21 8:03 ` Stefan Hajnoczi [this message]
2010-04-21 8:27 ` [Qemu-devel] " Yoshiaki Tamura
2010-04-23 9:53 ` Avi Kivity
2010-04-23 9:59 ` Yoshiaki Tamura
2010-04-23 13:14 ` Avi Kivity
2010-04-26 10:43 ` Yoshiaki Tamura
2010-04-23 13:26 ` Anthony Liguori
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 05/20] Introduce put_vector() and get_vector to QEMUFile and qemu_fopen_ops() Yoshiaki Tamura
2010-04-22 19:28 ` [Qemu-devel] " Anthony Liguori
2010-04-23 3:37 ` Yoshiaki Tamura
2010-04-23 13:22 ` Anthony Liguori
2010-04-23 13:48 ` Avi Kivity
2010-05-03 9:32 ` Yoshiaki Tamura
2010-05-03 12:05 ` Anthony Liguori
2010-05-03 15:36 ` Yoshiaki Tamura
2010-05-03 16:07 ` Anthony Liguori
2010-04-26 10:43 ` Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 06/20] Introduce iovec util functions, qemu_iovec_to_vector() and qemu_iovec_to_size() Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 07/20] Introduce qemu_put_vector() and qemu_put_vector_prepare() to use put_vector() in QEMUFile Yoshiaki Tamura
2010-04-22 19:29 ` [Qemu-devel] " Anthony Liguori
2010-04-23 4:02 ` Yoshiaki Tamura
2010-04-23 13:23 ` Anthony Liguori
2010-04-26 10:43 ` Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 08/20] Introduce RAMSaveIO and use cpu_physical_memory_get_dirty_range() to check multiple dirty pages Yoshiaki Tamura
2010-04-22 19:31 ` [Qemu-devel] " Anthony Liguori
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 09/20] Introduce writev and read to FdMigrationState Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 10/20] Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header Yoshiaki Tamura
2010-04-22 19:34 ` [Qemu-devel] " Anthony Liguori
2010-04-23 4:25 ` Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 11/20] Introduce some socket util functions Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 12/20] Introduce fault tolerant VM transaction QEMUFile and ft_mode Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 13/20] Introduce util functions to control ft_transaction from savevm layer Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 14/20] Upgrade QEMU_FILE_VERSION from 3 to 4, and introduce qemu_savevm_state_all() Yoshiaki Tamura
2010-04-22 19:37 ` [Qemu-devel] " Anthony Liguori
2010-04-23 3:29 ` Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 15/20] Introduce FT mode support to configure Yoshiaki Tamura
2010-04-22 19:38 ` [Qemu-devel] " Anthony Liguori
2010-04-23 3:09 ` Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 16/20] Introduce event_tap fucntions and ft_tranx_ready() Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 17/20] Modify migrate_fd_put_ready() when ft_mode is on Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 18/20] Modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 19/20] Insert do_event_tap() to virtio-{blk, net}, comment out assert() on cpu_single_env temporally Yoshiaki Tamura
2010-04-22 19:39 ` [Qemu-devel] " Anthony Liguori
2010-04-23 4:51 ` Yoshiaki Tamura
2010-04-21 5:57 ` [Qemu-devel] [RFC PATCH 20/20] Introduce -k option to enable FT migration mode (Kemari) Yoshiaki Tamura
2010-04-22 8:58 ` [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1 Dor Laor
2010-04-22 10:35 ` Yoshiaki Tamura
2010-04-22 11:36 ` Takuya Yoshikawa
2010-04-22 12:35 ` Yoshiaki Tamura
2010-04-22 12:19 ` Dor Laor
2010-04-22 13:16 ` Yoshiaki Tamura
2010-04-22 20:33 ` Anthony Liguori
2010-04-23 1:53 ` Yoshiaki Tamura
2010-04-23 13:20 ` Anthony Liguori
2010-04-26 10:44 ` Yoshiaki Tamura
2010-04-22 20:38 ` Dor Laor
2010-04-23 5:17 ` Yoshiaki Tamura
2010-04-23 7:36 ` Fernando Luis Vázquez Cao
2010-04-25 21:52 ` Dor Laor
2010-04-22 16:15 ` Jamie Lokier
2010-04-23 0:20 ` Yoshiaki Tamura
2010-04-23 15:07 ` Jamie Lokier
2010-04-22 19:42 ` [Qemu-devel] " Anthony Liguori
2010-04-23 0:45 ` Yoshiaki Tamura
2010-04-23 13:10 ` Anthony Liguori
2010-04-23 13:24 ` Avi Kivity
2010-04-26 10:44 ` Yoshiaki Tamura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q2ofbd9d3991004210103tbedf5823v6b9fadca6721f44d@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=ohmura.kei@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=tamura.yoshiaki@lab.ntt.co.jp \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).