From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O4UuW-0002iv-Ng
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 04:03:53 -0400
Received: from [140.186.70.92] (port=40049 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O4UuR-0002hk-VQ
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 04:03:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <stefanha@gmail.com>) id 1O4UuQ-0003SC-1b
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 04:03:47 -0400
Received: from mail-bw0-f224.google.com ([209.85.218.224]:58157)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefanha@gmail.com>) id 1O4UuP-0003Ru-OA
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 04:03:46 -0400
Received: by bwz24 with SMTP id 24so6656295bwz.17
	for <qemu-devel@nongnu.org>; Wed, 21 Apr 2010 01:03:44 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1271829445-5328-5-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
References: <1271829445-5328-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
	<1271829445-5328-5-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
Date: Wed, 21 Apr 2010 09:03:43 +0100
Message-ID: <q2ofbd9d3991004210103tbedf5823v6b9fadca6721f44d@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [RFC PATCH 04/20] Make QEMUFile buf expandable,
	and introduce qemu_realloc_buffer() and qemu_clear_buffer().
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: ohmura.kei@lab.ntt.co.jp, kvm@vger.kernel.org, mtosatti@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com

On Wed, Apr 21, 2010 at 6:57 AM, Yoshiaki Tamura
<tamura.yoshiaki@lab.ntt.co.jp> wrote:
> @@ -454,6 +458,25 @@ void qemu_fflush(QEMUFile *f)
> =A0 =A0 }
> =A0}
>
> +void *qemu_realloc_buffer(QEMUFile *f, int size)
> +{
> + =A0 =A0f->buf_max_size =3D size;
> +
> + =A0 =A0f->buf =3D qemu_realloc(f->buf, f->buf_max_size);
> + =A0 =A0if (f->buf =3D=3D NULL) {
> + =A0 =A0 =A0 =A0fprintf(stderr, "qemu file buffer realloc failed\n");
> + =A0 =A0 =A0 =A0exit(1);
> + =A0 =A0}
> +
> + =A0 =A0return f->buf;
> +}
> +

qemu_realloc() will abort() if there was not enough memory to realloc.
 Just like qemu_malloc(), you don't need to check for NULL.

Stefan