From: Blue Swirl <blauwirbel@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [RfC PATCH 08/11] spice: add qxl device
Date: Thu, 15 Apr 2010 19:47:07 +0300 [thread overview]
Message-ID: <r2zf43fc5581004150947i2fa7c91aq1aa4b861c466860d@mail.gmail.com> (raw)
In-Reply-To: <4BC64AD6.6040209@redhat.com>
On 4/15/10, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 04/14/2010 06:52 PM, Blue Swirl wrote:
>
> > On 4/14/10, Gerd Hoffmann<kraxel@redhat.com> wrote:
> >
> > > +static inline void atomic_or(uint32_t *var, uint32_t add)
> > > +{
> > > + __asm__ __volatile__ ("lock; orl %1, %0" : "+m" (*var) : "r" (add)
> : "memory");
> > > +}
> > >
> >
> > This will break on non-x86 hosts.
> >
>
> I'd just use __sync_fetch_and_or here.
And on environments without __sync_fetch_and_or? Where is that available?
next prev parent reply other threads:[~2010-04-15 16:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 9:55 [Qemu-devel] [RfC PATCH 00/11] Add spice support to qemu Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 01/11] vgabios update to 0.6c, add bios for qxl/unstable Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 02/11] add spice into the configure file Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 03/11] spice: core bits Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 04/11] spice: add keyboard Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 05/11] spice: add mouse Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 06/11] spice: simple display Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 07/11] spice: tls support Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 08/11] spice: add qxl device Gerd Hoffmann
2010-04-14 16:52 ` Blue Swirl
2010-04-14 23:08 ` [Qemu-devel] " Paolo Bonzini
2010-04-15 16:47 ` Blue Swirl [this message]
2010-04-15 19:27 ` Richard Henderson
2010-04-16 8:02 ` Gerd Hoffmann
2010-04-16 10:18 ` Paolo Bonzini
2010-04-16 10:34 ` Gerd Hoffmann
2010-04-16 12:53 ` Richard Henderson
2010-04-14 22:21 ` [Qemu-devel] " Alexander Graf
2010-04-16 8:08 ` Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 09/11] qxl: local rendering for sdl/vnc Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 10/11] spice: add tablet support Gerd Hoffmann
2010-04-14 9:55 ` [Qemu-devel] [RfC PATCH 11/11] spice: add audio Gerd Hoffmann
2010-04-14 20:51 ` malc
2010-04-14 23:14 ` [Qemu-devel] " Paolo Bonzini
2010-04-15 0:13 ` malc
2010-04-15 0:26 ` Paolo Bonzini
2010-04-15 0:29 ` malc
2010-04-16 8:40 ` [Qemu-devel] " Gerd Hoffmann
2010-04-16 11:13 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r2zf43fc5581004150947i2fa7c91aq1aa4b861c466860d@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).