From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6FE6C47096 for ; Sun, 6 Jun 2021 14:38:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 496EA61429 for ; Sun, 6 Jun 2021 14:38:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 496EA61429 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lptut-0007zh-5S for qemu-devel@archiver.kernel.org; Sun, 06 Jun 2021 10:38:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpttt-0006BV-I0 for qemu-devel@nongnu.org; Sun, 06 Jun 2021 10:37:17 -0400 Received: from mail01.asahi-net.or.jp ([202.224.55.13]:40553) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lptts-0006he-5X for qemu-devel@nongnu.org; Sun, 06 Jun 2021 10:37:17 -0400 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) (Authenticated sender: PQ4Y-STU) by mail01.asahi-net.or.jp (Postfix) with ESMTPA id F00FB11F0A8; Sun, 6 Jun 2021 23:37:13 +0900 (JST) Received: from localhost.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id A38EF1C0567; Sun, 6 Jun 2021 23:37:13 +0900 (JST) Date: Sun, 06 Jun 2021 23:37:11 +0900 Message-ID: From: Yoshinori Sato To: Peter Maydell Subject: Re: [PATCH 02/11] hw/char: remove sh_serial. In-Reply-To: References: <20210527052122.97103-1-ysato@users.sourceforge.jp> <20210527052122.97103-3-ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (arm-unknown-linux-androideabi) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: softfail client-ip=202.224.55.13; envelope-from=ysato@users.sourceforge.jp; helo=mail01.asahi-net.or.jp X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_BL=0.01, RCVD_IN_MSPIKE_L3=0.9, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 04 Jun 2021 19:08:07 +0900, Peter Maydell wrote: > > On Thu, 27 May 2021 at 06:24, Yoshinori Sato wrote: > > > > Migrate to renesas_sci. > > > > Signed-off-by: Yoshinori Sato > > --- > > hw/char/sh_serial.c | 431 -------------------------------------------- > > MAINTAINERS | 4 +- > > hw/char/Kconfig | 3 - > > hw/char/meson.build | 1 - > > 4 files changed, 2 insertions(+), 437 deletions(-) > > delete mode 100644 hw/char/sh_serial.c > > This won't compile, because there are still boards which use > the old code you are removing here. The patchset has to be able > to compile and work at every step, so you need to first add new > devices, then convert the boards to use them, and then as the > last step you can remove the old implementations. > > Checking, I find that patch 1 doesn't compile either. > > thanks > -- PMM OK. I will sent v2. -- Yoshinori Sato