From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22052C47096 for ; Sun, 6 Jun 2021 14:38:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEF0261429 for ; Sun, 6 Jun 2021 14:38:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEF0261429 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lptub-00076S-Ra for qemu-devel@archiver.kernel.org; Sun, 06 Jun 2021 10:38:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpttf-0005vT-QV for qemu-devel@nongnu.org; Sun, 06 Jun 2021 10:37:03 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:44144) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpttd-0006a2-QF for qemu-devel@nongnu.org; Sun, 06 Jun 2021 10:37:03 -0400 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id D5D6328BA7; Sun, 6 Jun 2021 23:36:58 +0900 (JST) Received: from localhost.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 34D4A1C03C0; Sun, 6 Jun 2021 23:36:58 +0900 (JST) Date: Sun, 06 Jun 2021 23:36:56 +0900 Message-ID: From: Yoshinori Sato To: Peter Maydell Subject: Re: [PATCH 01/11] hw/char: Renesas SCI module. In-Reply-To: References: <20210527052122.97103-1-ysato@users.sourceforge.jp> <20210527052122.97103-2-ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (arm-unknown-linux-androideabi) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: softfail client-ip=202.224.55.14; envelope-from=ysato@users.sourceforge.jp; helo=mail02.asahi-net.or.jp X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL=1.31, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 04 Jun 2021 18:09:44 +0900, Peter Maydell wrote: > > On Thu, 27 May 2021 at 06:30, Yoshinori Sato wrote: > > > > This module supported SCI / SCIa / SCIF. > > > > Hardware manual. > > SCI / SCIF > > https://www.renesas.com/us/en/doc/products/mpumcu/001/r01uh0457ej0401_sh7751.pdf > > SCIa > > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf > > > > Signed-off-by: Yoshinori Sato > > --- > > include/hw/char/renesas_sci.h | 129 +++- > > hw/char/renesas_sci.c | 1039 +++++++++++++++++++++++++++------ > > 2 files changed, 966 insertions(+), 202 deletions(-) > > This patch is much too large to review. Could you split it up into > multiple logical pieces, please? OK. I will snt v2. > > > > > diff --git a/include/hw/char/renesas_sci.h b/include/hw/char/renesas_sci.h > > index a4764e3eee..ae9554db60 100644 > > --- a/include/hw/char/renesas_sci.h > > +++ b/include/hw/char/renesas_sci.h > > @@ -1,54 +1,137 @@ > > /* > > * Renesas Serial Communication Interface > > * > > - * Copyright (c) 2018 Yoshinori Sato > > + * Copyright (c) 2020 Yoshinori Sato > > + * > > + * This code is licensed under the GPL version 2 or later. > > * > > - * SPDX-License-Identifier: GPL-2.0-or-later > > Did you have a reason for deleting the SPDX line ? > > > */ > > > > -#ifndef HW_CHAR_RENESAS_SCI_H > > -#define HW_CHAR_RENESAS_SCI_H > > - > > Why have you deleted the multiple-include guard? > > thanks > -- PMM -- Yoshinori Sato