From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX4o2-0001kQ-Qj for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:21:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WX4nv-0001ui-2o for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:21:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60844 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX4nu-0001uY-Ru for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:21:19 -0400 Date: Mon, 07 Apr 2014 10:21:17 +0200 Message-ID: From: Takashi Iwai In-Reply-To: <1396858063.5001.49.camel@nilsson.home.kraxel.org> References: <1396608084-26986-1-git-send-email-tiwai@suse.de> <1396608084-26986-5-git-send-email-tiwai@suse.de> <1396858063.5001.49.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Anthony Liguori , Cole Robinson At Mon, 07 Apr 2014 10:07:43 +0200, Gerd Hoffmann wrote: > > On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: > > I simply like it better, you don't? :) > > I still think we should make this simply depend on absolute/relative > pointer mode instead of asking the user to switch it manually. Yes, agreed, it's more intuitive. OTOH, we still want the explicit input grab in absolute mode. So, we'll need two flags in the end, the explicit grab by menu or key combo, and the implicit grab by click in relative mode. > I'll quickly go put patches 1-3 into a 2.0 pull request, so debating > patch #4 doesn't stop the clear improvements from entering the tree. Thanks! Takashi