From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41539)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nkukard+qemu@lbsd.net>) id 1WF46A-0003xq-9Y
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 10:57:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nkukard+qemu@lbsd.net>) id 1WF465-0003aO-9S
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 10:57:42 -0500
Received: from gbr.mailhost.iitsp.com ([217.147.85.13]:36475)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nkukard+qemu@lbsd.net>) id 1WF464-0003aE-VW
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 10:57:37 -0500
Message-ID: <sig.11242c0a74.5300DFE5.3050402@lbsd.net>
Date: Sun, 16 Feb 2014 15:57:25 +0000
From: Nigel Kukard <nkukard+qemu@lbsd.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Hotplug vs. multifunction regression
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi guys,

Starting from the patch series in 9f117d41 the below error is
observed... (reverting to the patch right before it works fine a1483f88)

Here is the error:
qemu-system-x86_64: hw/pci/pcie.c:240: pcie_cap_slot_hotplug_common:
Assertion `((pci_dev->devfn) & 0x07) == 0' failed.

Here is the command that generated it...

CMDLINE: $VAR1 = [
          'qemu-system-x86_64',
          '-m',
          '8G',
          '-machine',
          'q35',
          '-cpu',
          'qemu64',
          '-smp',
          '4,sockets=1,cores=4,threads=1',
          '-enable-kvm',
          '-device',
         
'ioh3420,bus=pcie.0,addr=1c.0,multifunction=on,port=1,chassis=1,id=root.1',
          '-device',
         
'vfio-pci,host=03:00.0,bus=root.1,addr=0.0,multifunction=on,x-vga=on',
          '-device',
          'vfio-pci,host=03:00.1,bus=root.1,addr=0.1',
          '-device',
          'ide-drive,drive=sata-disk0,bus=ide.0',
          '-drive',
         
'file=510-drive_sda.qcow2,id=sata-disk0,format=qcow2,cache=writeback,if=none',
          '-vga',
          'none',
          '-nographic',
          '-boot',
          'menu=on',
        ];

It seems the hotplug interface doesn't know how to handle multifunction
devices.

-N