From: "Hang Yu" <1339236493@qq.com>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-devel <qemu-devel@nongnu.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
komlodi <komlodi@google.com>, peter <peter@pjd.dev>
Subject: Re: [PATCH] Aspeed: i2c: Fixed Tx and Rx error in BUFF Mode
Date: Thu, 10 Aug 2023 21:55:14 +0800 [thread overview]
Message-ID: <tencent_401D7E692D9798C9F7752312A1159240F605@qq.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 7094 bytes --]
Hello
> Hello,
>
> On 8/4/23 10:11, Hang Yu via wrote:
> > 1. Fixed inconsistency between the bit field definition in register
> > I2CD_POOL_CTRL and the ast2600 datasheet
> > 2. Fixed issue of confusing RXSIZE and RXCOUNT, as well as forgetting
> > to add one to TXCOUNT and RXSIZE in buff mode
> > 3. Fixed issue with TXBUF transmission start position error in buff mode
> > 4. Added support for the BUFFER ORGANIZATION option in reg I2CC_POOL_CTRL
>
>
> This looks like 4 patches. Could split and resend a series please ?
Ok,I will split it. However, it should be noted that pool mode will only work if the first three patches have been applied.
>
> Also, Cc: these persons
>
> Joe Komlodi
> Peter Delevoryas
>
> since they have been involved with the AST2600 I2C implementation.
>
> > After adding these changes, QEMU can support driver code:
> > https://github.com/AspeedTech-BMC/linux/blob/aspeed-master-v5.15
> > /drivers/i2c/busses/i2c-ast2600.c
> >
> > Signed-off-by: Hang Yu <1339236493@qq.com>
>
> This is very cryptic. Don't you have a corporate email ?
Sorry, because I am still a student and do not have a corporate email, I have used a private email. When submitting the patch next time, I will switch to my student email.
>
> Thanks,
>
> C.
>
>
>
Thanks，
Hang Yu
> > ---
> > hw/i2c/aspeed_i2c.c | 21 ++++++---------------
> > include/hw/i2c/aspeed_i2c.h | 5 +++--
> > 2 files changed, 9 insertions(+), 17 deletions(-)
> >
> > diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c
> > index 1f071a3811..0e380d0bba 100644
> > --- a/hw/i2c/aspeed_i2c.c
> > +++ b/hw/i2c/aspeed_i2c.c
> > @@ -236,7 +236,7 @@ static int aspeed_i2c_bus_send(AspeedI2CBus *bus, uint8_t pool_start)
> > uint32_t reg_byte_buf = aspeed_i2c_bus_byte_buf_offset(bus);
> > uint32_t reg_dma_len = aspeed_i2c_bus_dma_len_offset(bus);
> > int pool_tx_count = SHARED_ARRAY_FIELD_EX32(bus->regs, reg_pool_ctrl,
> > - TX_COUNT);
> > + TX_COUNT)+1;
> >
> > if (SHARED_ARRAY_FIELD_EX32(bus->regs, reg_cmd, TX_BUFF_EN)) {
> > for (i = pool_start; i < pool_tx_count; i++) {
> > @@ -293,10 +293,12 @@ static void aspeed_i2c_bus_recv(AspeedI2CBus *bus)
> > uint32_t reg_dma_len = aspeed_i2c_bus_dma_len_offset(bus);
> > uint32_t reg_dma_addr = aspeed_i2c_bus_dma_addr_offset(bus);
> > int pool_rx_count = SHARED_ARRAY_FIELD_EX32(bus->regs, reg_pool_ctrl,
> > - RX_COUNT);
> > + RX_SIZE)+1;
> >
> > if (SHARED_ARRAY_FIELD_EX32(bus->regs, reg_cmd, RX_BUFF_EN)) {
> > - uint8_t *pool_base = aic->bus_pool_base(bus);
> > + uint8_t *pool_base ;
> > + if(ARRAY_FIELD_EX32(bus->regs,I2CC_POOL_CTRL,BUF_ORGANIZATION))pool_base=aic->bus_pool_base(bus)+16;
> > + else pool_base= aic->bus_pool_base(bus);
> >
> > for (i = 0; i < pool_rx_count; i++) {
> > pool_base[i] = i2c_recv(bus->bus);
> > @@ -418,7 +420,7 @@ static void aspeed_i2c_bus_cmd_dump(AspeedI2CBus *bus)
> > uint32_t reg_intr_sts = aspeed_i2c_bus_intr_sts_offset(bus);
> > uint32_t reg_dma_len = aspeed_i2c_bus_dma_len_offset(bus);
> > if (SHARED_ARRAY_FIELD_EX32(bus->regs, reg_cmd, RX_BUFF_EN)) {
> > - count = SHARED_ARRAY_FIELD_EX32(bus->regs, reg_pool_ctrl, TX_COUNT);
> > + count = SHARED_ARRAY_FIELD_EX32(bus->regs, reg_pool_ctrl, TX_COUNT)+1;
> > } else if (SHARED_ARRAY_FIELD_EX32(bus->regs, reg_cmd, RX_DMA_EN)) {
> > count = bus->regs[reg_dma_len];
> > } else { /* BYTE mode */
> > @@ -449,7 +451,6 @@ static void aspeed_i2c_bus_handle_cmd(AspeedI2CBus *bus, uint64_t value)
> > uint8_t pool_start = 0;
> > uint32_t reg_intr_sts = aspeed_i2c_bus_intr_sts_offset(bus);
> > uint32_t reg_cmd = aspeed_i2c_bus_cmd_offset(bus);
> > - uint32_t reg_pool_ctrl = aspeed_i2c_bus_pool_ctrl_offset(bus);
> > uint32_t reg_dma_len = aspeed_i2c_bus_dma_len_offset(bus);
> >
> > if (!aspeed_i2c_check_sram(bus)) {
> > @@ -489,16 +490,6 @@ static void aspeed_i2c_bus_handle_cmd(AspeedI2CBus *bus, uint64_t value)
> > * else needs to be sent in this sequence.
> > */
> > if (SHARED_ARRAY_FIELD_EX32(bus->regs, reg_cmd, TX_BUFF_EN)) {
> > - if (SHARED_ARRAY_FIELD_EX32(bus->regs, reg_pool_ctrl, TX_COUNT)
> > - == 1) {
> > - SHARED_ARRAY_FIELD_DP32(bus->regs, reg_cmd, M_TX_CMD, 0);
> > - } else {
> > - /*
> > - * Increase the start index in the TX pool buffer to
> > - * skip the address byte.
> > - */
> > - pool_start++;
> > - }
> > } else if (SHARED_ARRAY_FIELD_EX32(bus->regs, reg_cmd, TX_DMA_EN)) {
> > if (bus->regs[reg_dma_len] == 0) {
> > SHARED_ARRAY_FIELD_DP32(bus->regs, reg_cmd, M_TX_CMD, 0);
> > diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h
> > index 51c944efea..88b144a599 100644
> > --- a/include/hw/i2c/aspeed_i2c.h
> > +++ b/include/hw/i2c/aspeed_i2c.h
> > @@ -139,9 +139,9 @@ REG32(I2CD_CMD, 0x14) /* I2CD Command/Status */
> > REG32(I2CD_DEV_ADDR, 0x18) /* Slave Device Address */
> > SHARED_FIELD(SLAVE_DEV_ADDR1, 0, 7)
> > REG32(I2CD_POOL_CTRL, 0x1C) /* Pool Buffer Control */
> > - SHARED_FIELD(RX_COUNT, 24, 5)
> > + SHARED_FIELD(RX_COUNT, 24, 6)
> > SHARED_FIELD(RX_SIZE, 16, 5)
> > - SHARED_FIELD(TX_COUNT, 9, 5)
> > + SHARED_FIELD(TX_COUNT, 8, 5)
> > FIELD(I2CD_POOL_CTRL, OFFSET, 2, 6) /* AST2400 */
> > REG32(I2CD_BYTE_BUF, 0x20) /* Transmit/Receive Byte Buffer */
> > SHARED_FIELD(RX_BUF, 8, 8)
> > @@ -162,6 +162,7 @@ REG32(I2CC_MS_TXRX_BYTE_BUF, 0x08)
> > /* 15:0 shared with I2CD_BYTE_BUF[15:0] */
> > REG32(I2CC_POOL_CTRL, 0x0c)
> > /* 31:0 shared with I2CD_POOL_CTRL[31:0] */
> > + FIELD(I2CC_POOL_CTRL, BUF_ORGANIZATION, 0, 1) /* AST2600 */
> > REG32(I2CM_INTR_CTRL, 0x10)
> > REG32(I2CM_INTR_STS, 0x14)
> > FIELD(I2CM_INTR_STS, PKT_STATE, 28, 4)
[-- Attachment #2: Type: text/html, Size: 31705 bytes --]
next reply other threads:[~2023-08-10 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 13:55 Hang Yu [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-04 8:11 [PATCH] Aspeed: i2c: Fixed Tx and Rx error in BUFF Mode Hang Yu via
2023-08-10 9:13 ` Cédric Le Goater
2023-08-04 7:50 于航 via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_401D7E692D9798C9F7752312A1159240F605@qq.com \
--to=1339236493@qq.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=komlodi@google.com \
--cc=peter.maydell@linaro.org \
--cc=peter@pjd.dev \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).