From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Chunqiang (CQ) Tang" <tangchq@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] thread synchronization in qcow2.c and qcow2-cluster.c
Date: Tue, 27 Apr 2010 22:26:46 +0100 [thread overview]
Message-ID: <u2ifbd9d3991004271426v356d5ff7u46e16325dfa722d8@mail.gmail.com> (raw)
In-Reply-To: <k2v50c1b8771004271339zf55a7abej8251f18169e5d3a2@mail.gmail.com>
On Tue, Apr 27, 2010 at 9:39 PM, Chunqiang (CQ) Tang <tangchq@gmail.com> wrote:
> Thank you for the information. I also suspected that
> qemu_mutex_lock_iothread() does the synchronization. However, my
> profiling showed that qemu-kvm.c:kvm_cpu_exec() in is actually
> executed, instead of kvm-all.c:kvm_cpu_exec().
Are you using qemu-kvm.git?
Can you double check that qemu-kvm.o is being linked in instead of kvm-all.o?
I looked at the link map for qemu-system-x86_64 and verified that
kvm-all.o is linked in and qemu-kvm.o is not linked in.
Stefan
diff --git a/Makefile.target b/Makefile.target
index 1ffd802..122b951 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -30,6 +30,7 @@ endif
PROGS=$(QEMU_PROG)
+LDFLAGS+=-Wl,-Map=$(QEMU_PROG).map
LIBS+=-lm
kvm.o kvm-all.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
next prev parent reply other threads:[~2010-04-27 21:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 16:06 [Qemu-devel] thread synchronization in qcow2.c and qcow2-cluster.c Chunqiang (CQ) Tang
2010-04-27 19:49 ` Stefan Hajnoczi
2010-04-27 20:39 ` Chunqiang (CQ) Tang
2010-04-27 21:26 ` Stefan Hajnoczi [this message]
2010-04-28 8:13 ` Stefan Hajnoczi
2010-04-28 14:59 ` Chunqiang (CQ) Tang
2010-04-28 9:08 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u2ifbd9d3991004271426v356d5ff7u46e16325dfa722d8@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=tangchq@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).