From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O3QEM-000370-Na for qemu-devel@nongnu.org; Sun, 18 Apr 2010 04:51:54 -0400 Received: from [140.186.70.92] (port=37136 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O3QEH-00034Y-SL for qemu-devel@nongnu.org; Sun, 18 Apr 2010 04:51:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O3QEG-0005w7-LX for qemu-devel@nongnu.org; Sun, 18 Apr 2010 04:51:49 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:47306) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O3QEG-0005vz-G1 for qemu-devel@nongnu.org; Sun, 18 Apr 2010 04:51:48 -0400 Received: by pwi6 with SMTP id 6so2610357pwi.4 for ; Sun, 18 Apr 2010 01:51:46 -0700 (PDT) MIME-Version: 1.0 Date: Sun, 18 Apr 2010 11:51:46 +0300 Message-ID: From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] [RFC, PATCH 1/2] bt-l2cap: fix if statement with empty body, spotted by clang List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrzej Zaborowski , qemu-devel Fix clang error: CC bt-l2cap.o /src/qemu/hw/bt-l2cap.c:1000:41: error: if statement has empty body [-Wempty-body] /* TODO: Signal an error? */; This means that l2cap_sframe_in() may now get called. Signed-off-by: Blue Swirl --- hw/bt-l2cap.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/bt-l2cap.c b/hw/bt-l2cap.c index 70d731e..7e2f668 100644 --- a/hw/bt-l2cap.c +++ b/hw/bt-l2cap.c @@ -996,10 +996,10 @@ static void l2cap_iframe_in(struct l2cap_chan_s *ch, uint16_t cid, l2cap_rexmit_enable(ch, !(hdr->data[0] >> 7)); if (hdr->data[0] & 1) { - if (len != 4) - /* TODO: Signal an error? */; + if (len != 4) { + /* TODO: Signal an error? */ return; - + } return l2cap_sframe_in(ch, le16_to_cpup((void *) hdr->data)); } -- 1.6.2.4