* [Qemu-devel] [RFC, PATCH 1/2] bt-l2cap: fix if statement with empty body, spotted by clang
@ 2010-04-18 8:51 Blue Swirl
0 siblings, 0 replies; only message in thread
From: Blue Swirl @ 2010-04-18 8:51 UTC (permalink / raw)
To: Andrzej Zaborowski, qemu-devel
Fix clang error:
CC bt-l2cap.o
/src/qemu/hw/bt-l2cap.c:1000:41: error: if statement has empty body
[-Wempty-body]
/* TODO: Signal an error? */;
This means that l2cap_sframe_in() may now get called.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
hw/bt-l2cap.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/bt-l2cap.c b/hw/bt-l2cap.c
index 70d731e..7e2f668 100644
--- a/hw/bt-l2cap.c
+++ b/hw/bt-l2cap.c
@@ -996,10 +996,10 @@ static void l2cap_iframe_in(struct l2cap_chan_s
*ch, uint16_t cid,
l2cap_rexmit_enable(ch, !(hdr->data[0] >> 7));
if (hdr->data[0] & 1) {
- if (len != 4)
- /* TODO: Signal an error? */;
+ if (len != 4) {
+ /* TODO: Signal an error? */
return;
-
+ }
return l2cap_sframe_in(ch, le16_to_cpup((void *) hdr->data));
}
--
1.6.2.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-18 8:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-18 8:51 [Qemu-devel] [RFC, PATCH 1/2] bt-l2cap: fix if statement with empty body, spotted by clang Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).