From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NyKDO-0005G1-Jj
	for qemu-devel@nongnu.org; Sun, 04 Apr 2010 03:25:50 -0400
Received: from [140.186.70.92] (port=38845 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NyKDC-00057M-Cy
	for qemu-devel@nongnu.org; Sun, 04 Apr 2010 03:25:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1NyKD5-0000ow-U0
	for qemu-devel@nongnu.org; Sun, 04 Apr 2010 03:25:38 -0400
Received: from mail-pz0-f179.google.com ([209.85.222.179]:40715)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1NyKD3-0000oN-Ah
	for qemu-devel@nongnu.org; Sun, 04 Apr 2010 03:25:31 -0400
Received: by pzk9 with SMTP id 9so745083pzk.19
	for <qemu-devel@nongnu.org>; Sun, 04 Apr 2010 00:25:28 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4BB83BC4.5040005@redhat.com>
References: <p2nf43fc5581004020846j43d3ea6bt8cb9955a2b1db0b@mail.gmail.com>
	<1270227919-31031-1-git-send-email-pbonzini@redhat.com>
	<z2gf43fc5581004021029j56b6b220w5a11f0b218ae7e2e@mail.gmail.com>
	<4BB62A74.6090109@redhat.com>
	<y2sf43fc5581004021117nb2cfdcccr17b3a4f4acd8c0f7@mail.gmail.com>
	<4BB63869.9090301@redhat.com>
	<w2yf43fc5581004021204w62027b44m2d2ba98d94d2dbe0@mail.gmail.com>
	<4BB70490.6000506@redhat.com>
	<k2lf43fc5581004030207i1b8a80den9fe7439bfa72f771@mail.gmail.com>
	<4BB83BC4.5040005@redhat.com>
Date: Sun, 4 Apr 2010 10:25:28 +0300
Message-ID: <u2tf43fc5581004040025r8ed5cc93xca1ad94c662bdfcc@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if
	!CONFIG_KVM
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 4/4/10, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 04/03/2010 11:07 AM, Blue Swirl wrote:
>
> > On 4/3/10, Paolo Bonzini<pbonzini@redhat.com>  wrote:
> >
> > > On 04/02/2010 09:04 PM, Blue Swirl wrote:
> > >
> > >
> > > > -int kvm_init(int smp_cpus);
> > > >
> > > >
> > >
> > >  I had missed this; I don't see a particular reason to move this out of
> > > kvm.h.  Anyway I don't feel strongly about this.
> > >
> >
> > The reason is to avoid including kvm.h by vl.c.
> >
>
>  But that's not a problem, kvm.h can be included by compiled-once files;
> that was the reason to introduce the stubs in the first place.  kvm_* should
> be declared in kvm.h.

That can't be safe because CONFIG_KVM will not be defined for files
compiled once. So even with the stubs, those files would use inlined
stubs where they shouldn't.