From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1OA5I0-0003wU-AE for qemu-devel@nongnu.org; Thu, 06 May 2010 13:55:12 -0400 Received: from [140.186.70.92] (port=37563 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OA5Hy-0003vg-OH for Qemu-devel@nongnu.org; Thu, 06 May 2010 13:55:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OA5Hw-0000f5-U1 for Qemu-devel@nongnu.org; Thu, 06 May 2010 13:55:10 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:34541) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA5Hw-0000em-PG for Qemu-devel@nongnu.org; Thu, 06 May 2010 13:55:08 -0400 Received: by pwi6 with SMTP id 6so99249pwi.4 for ; Thu, 06 May 2010 10:55:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4BE129F0.8000905@redhat.com> References: <4BE129F0.8000905@redhat.com> Date: Thu, 6 May 2010 20:55:06 +0300 Message-ID: From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] Re: [Commit 20d97356] Fix OpenBSD build List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Qemu-devel@nongnu.org On 5/5/10, Kevin Wolf wrote: > Hi Blue Swirl, > > did I miss the patch posted for this commit? I can't find it on the > mailing list. I think the BlockDriver declarations should really stay at > the end of the source file of each driver. > > What about using a different way to get rid of the static forward > declaration, namely using bdrv_find_format() instead of referencing it > directly? If you agree I'll post patches to revert your change and use > this solution instead. Somehow I can't form in my mind the change from your description, but I'd be fine with that too if it also compiles in OpenBSD.