From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O34VP-0007Vd-Tp
	for qemu-devel@nongnu.org; Sat, 17 Apr 2010 05:40:03 -0400
Received: from [140.186.70.92] (port=55758 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O34VM-0007VJ-Oh
	for qemu-devel@nongnu.org; Sat, 17 Apr 2010 05:40:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <stefanha@gmail.com>) id 1O34VL-00025E-7a
	for qemu-devel@nongnu.org; Sat, 17 Apr 2010 05:40:00 -0400
Received: from mail-qy0-f181.google.com ([209.85.221.181]:55350)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefanha@gmail.com>) id 1O34VL-000257-58
	for qemu-devel@nongnu.org; Sat, 17 Apr 2010 05:39:59 -0400
Received: by qyk11 with SMTP id 11so3304359qyk.13
	for <qemu-devel@nongnu.org>; Sat, 17 Apr 2010 02:39:58 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1271447998-24718-4-git-send-email-kwolf@redhat.com>
References: <1271447998-24718-1-git-send-email-kwolf@redhat.com>
	<1271447998-24718-4-git-send-email-kwolf@redhat.com>
Date: Sat, 17 Apr 2010 10:39:57 +0100
Message-ID: <y2nfbd9d3991004170239s3e25b03fs757f71e188dca36d@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] vmdk: Convert to bdrv_open
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On Fri, Apr 16, 2010 at 8:59 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 781518a..27b6360 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -835,14 +828,12 @@ static void vmdk_close(BlockDriverState *bs)
> =A0 =A0 qemu_free(s->l1_table);
> =A0 =A0 qemu_free(s->l2_cache);
> =A0 =A0 // try to close parent image, if exist
> - =A0 =A0vmdk_parent_close(s->hd);
> - =A0 =A0bdrv_delete(s->hd);
> + =A0 =A0vmdk_parent_close(bs->file);
> =A0}

block.c:bdrv_close() calls bdrv_delete(bs->backing_hd) before
bs->bdrv_close().  The vmdk format doesn't need to explicitly close
its parent file and the vmdk_parent_close() function can be deleted.
vmdk.c is the only block driver that explicitly closes or deletes
backing_hd.

Stefan