From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39826)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sandmann@cs.au.dk>) id 1T8aWh-0004LN-Qb
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 13:33:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sandmann@cs.au.dk>) id 1T8aWg-0006lc-Uj
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 13:33:31 -0400
Received: from smtp.nfit.au.dk ([130.225.17.180]:39643 helo=nysmtp.nfit.au.dk)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sandmann@cs.au.dk>) id 1T8aWg-0006lS-NX
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 13:33:30 -0400
From: sandmann@cs.au.dk (=?utf-8?Q?S=C3=B8ren?= Sandmann)
References: <704493541.25479840.1346657644362.JavaMail.root@redhat.com>
Date: Mon, 03 Sep 2012 19:33:27 +0200
In-Reply-To: <704493541.25479840.1346657644362.JavaMail.root@redhat.com> (Alon
	Levy's message of "Mon, 3 Sep 2012 03:34:04 -0400")
Message-ID: <ye8d3239fko.fsf@llama04.cs.au.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH-v2 spice 1/2] Set a8 capability in the
	QXL	device if supported by the client
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org, spice-devel@lists.freedesktop.org, =?utf-8?Q?S=C3=B8ren?= Sandmann Pedersen <ssp@redhat.com>, kraxel@redhat.com

Alon Levy <alevy@redhat.com> writes:

>> ---
>>  server/red_worker.c | 2 ++
>>  spice-common        | 2 +-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/server/red_worker.c b/server/red_worker.c
>> index 843f559..23f3464 100644
>> --- a/server/red_worker.c
>> +++ b/server/red_worker.c
>> @@ -10377,6 +10377,8 @@ static void
>> handle_new_display_channel(RedWorker *worker, RedClient *client, Red
>>              SET_CAP(caps, SPICE_DISPLAY_CAP_MONITORS_CONFIG);
>>          if (red_channel_client_test_remote_cap(rcc,
>>          SPICE_DISPLAY_CAP_COMPOSITE))
>>              SET_CAP(caps, SPICE_DISPLAY_CAP_COMPOSITE);
>> +        if (red_channel_client_test_remote_cap(rcc,
>> SPICE_DISPLAY_CAP_COMPOSITE))
>> +            SET_CAP(caps, SPICE_DISPLAY_CAP_A8_SURFACE);
>
> Didn't you mean to test remote SPICE_DISPLAY_CAP_A8_SURFACE?

Yes, good catch. I'll fix before pushing.

Thanks,
Soren