From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF173C38145 for ; Thu, 8 Sep 2022 16:25:34 +0000 (UTC) Received: from localhost ([::1]:36402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWKLN-00032e-Sd for qemu-devel@archiver.kernel.org; Thu, 08 Sep 2022 12:25:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWK6x-0000mi-N1; Thu, 08 Sep 2022 12:10:39 -0400 Received: from sosiego.soundray.org ([2a01:4f8:c2c:a9a0::1]:53874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWK6v-0005vx-8r; Thu, 08 Sep 2022 12:10:39 -0400 From: Linus Heckemann DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sphalerite.org; s=sosiego; t=1662653431; bh=Uwe4YGz1W6ZqpkIxdQQY+a2Ar6vDLizTjQrQWwEPO4c=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=2uWpeA8QTW2E9sQxpzYSVIoPd2iVt3FqMEROBnd2WqAK7QKH/WcNEvl2j+F0UCstN +Sq5wyjQ1W3UteWaqDfQcDKdgnJf+L/eJkLSnBlU8jdE1XtTabPS3yNJKXH//cVfTK QrHkawAjU/pxPX7nUMkTmVqyLIMh6J/K9fwTQA20= To: Greg Kurz Cc: qemu-devel@nongnu.org, Christian Schoenebeck , Qemu-block , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Daniel_P_=2E_Berrang=C3=A9?= Subject: Re: [PATCH v3] 9pfs: use GHashTable for fid table In-Reply-To: <20220908141841.6a451d85@bahia> References: <20220908112353.289267-1-git@sphalerite.org> <20220908141841.6a451d85@bahia> Date: Thu, 08 Sep 2022 18:10:28 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:c2c:a9a0::1; envelope-from=git@sphalerite.org; helo=sosiego.soundray.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" (sorry for the dup @Greg, forgot to reply-all) Greg Kurz writes: >> > g_hash_table_steal_extended() [1] actually allows to do just that. >> >> g_hash_table_steal_extended unfortunately isn't available since it was >> introduced in glib 2.58 and we're maintaining compatibility to 2.56. >> > > Ha... this could be addressed through conditional compilation, e.g.: It still won't compile, because we set GLIB_VERSION_MAX_ALLOWED in glib-compat.h and it would require a compat wrapper as described there. I think that's a bit much for this far more marginal performance change. I'm happy to resubmit with the TODO comment though if you like?