qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Linus Heckemann <git@sphalerite.org>
To: Alyssa Ross <hi@alyssa.is>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] docs/devel: remove incorrect claim about git send-email
Date: Tue, 11 Oct 2022 12:39:56 +0200	[thread overview]
Message-ID: <ygay1tmej9f.fsf@localhost> (raw)
In-Reply-To: <87o7vemq0c.fsf@alyssa.is>

Alyssa Ross <hi@alyssa.is> writes:

> Alyssa Ross <hi@alyssa.is> writes:
>
>> Linus Heckemann <git@sphalerite.org> writes:
>>
>>> While it's unclear to me what git send-email actually does with the
>>> -v2 parameter (it is not documented, but also not rejected), it does
>>> not add a v2 tag to the email's subject, which is what led to the
>>> mishap in [1].
>>>
>>> [1]: https://lists.nongnu.org/archive/html/qemu-devel/2022-09/msg00679.html
>>
>> It does for me!
>>
>> Tested with:
>>
>>        git send-email -v2 --to hi@alyssa.is HEAD~
>>
>> X-Mailer: git-send-email 2.37.1
>
> I wouldn't be surprised if it only adds it when it's generating the
> patch though.  Did you perhaps run git format-patch first to generate a
> patch file, and then use git send-email to send it?

Yes! I didn't realise that git send-email can be used without the
intermediate format-patch step. I guess it's a git bug that git
send-email will silently ignore -v when used with a patch file. I'll
have a look at fixing that.


  reply	other threads:[~2022-10-11 11:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 16:52 [PATCH] docs/devel: remove incorrect claim about git send-email Linus Heckemann
2022-09-17  7:12 ` Alyssa Ross
2022-09-17  7:14   ` Alyssa Ross
2022-10-11 10:39     ` Linus Heckemann [this message]
2022-10-16 16:37       ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ygay1tmej9f.fsf@localhost \
    --to=git@sphalerite.org \
    --cc=hi@alyssa.is \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).