qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jun Koi <junkoi2004@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] A bit optimization for tlb_set_page()
Date: Tue, 27 Apr 2010 12:25:09 +0900	[thread overview]
Message-ID: <z2jfdaac4d51004262025o432d94f2xe474e09efd1fd634@mail.gmail.com> (raw)

It is not necessary to continue searching for watchpoint when we
already found one and setup for handling watchpoint in a search loop
in tlb_set_page().
This patch breaks that search loop on then.

Signed-off-by: Jun Koi <junkoi2004@gmail.com>

diff --git a/exec.c b/exec.c
index 14d1fd7..6329775 100644
--- a/exec.c
+++ b/exec.c
@@ -2240,6 +2240,7 @@ void tlb_set_page(CPUState *env, target_ulong vaddr,
             /* TODO: The memory case can be optimized by not trapping
                reads of pages with a write breakpoint.  */
             address |= TLB_MMIO;
+            break;
         }
     }

             reply	other threads:[~2010-04-27  3:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27  3:25 Jun Koi [this message]
2010-04-27 18:36 ` [Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page() Jan Kiszka
2010-04-27 23:48   ` Jun Koi
2010-04-28  2:52     ` Jun Koi
2010-04-28  6:53       ` Jan Kiszka
2010-04-28  7:13         ` Jun Koi
2010-04-30  6:44           ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=z2jfdaac4d51004262025o432d94f2xe474e09efd1fd634@mail.gmail.com \
    --to=junkoi2004@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).