From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O4lgG-0002Le-Pl
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 21:58:16 -0400
Received: from [140.186.70.92] (port=43416 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O4lgE-0002Kg-UD
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 21:58:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <balrogg@gmail.com>) id 1O4lg9-0000al-3u
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 21:58:14 -0400
Received: from mail-bw0-f211.google.com ([209.85.218.211]:59207)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <balrogg@gmail.com>) id 1O4lg8-0000ag-Sc
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 21:58:09 -0400
Received: by bwz3 with SMTP id 3so7397421bwz.11
	for <qemu-devel@nongnu.org>; Wed, 21 Apr 2010 18:58:07 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <p2wf43fc5581004180152nee126c14kef1be12038ab2cb0@mail.gmail.com>
References: <p2wf43fc5581004180152nee126c14kef1be12038ab2cb0@mail.gmail.com>
Date: Thu, 22 Apr 2010 03:58:07 +0200
Message-ID: <z2nfb249edb1004211858w47052450tb253fda15e94b0a1@mail.gmail.com>
From: andrzej zaborowski <balrogg@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [RFC,
	PATCH 2/2] bt-sdp: Fix if statement with empty body,
	spotted by clang
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 18 April 2010 10:52, Blue Swirl <blauwirbel@gmail.com> wrote:
> Fix clang error:
> =C2=A0CC =C2=A0 =C2=A0bt-sdp.o
> /src/qemu/hw/bt-sdp.c:174:17: error: if statement has empty body [-Wempty=
-body]
> =C2=A0 =C2=A0if (len > 1);
>
> However, fixing this means that some code that was previously
> ignored by the compiler now gets compiled, resulting in this error:
> =C2=A0CC =C2=A0 =C2=A0bt-sdp.o
> cc1: warnings being treated as errors
> /src/qemu/hw/bt-sdp.c: In function 'sdp_svc_search':
> /src/qemu/hw/bt-sdp.c:184: error: 'max' may be used uninitialized in
> this function
>
> I could not figure out how to calculate max, so I just invented some
> figure to suppress the error.

Thanks, good catches, I applied fixes to both problems.

Turns out we were assigning the value of the "Max" parameter of the
request to the wrong variable, which was later overwritten anyway.  I
don't know what I was thinking...

Cheers