From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O6uWC-0006EI-Ss
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 19:48:44 -0400
Received: from [140.186.70.92] (port=50220 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O6uWB-0006E9-Ni
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 19:48:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <junkoi2004@gmail.com>) id 1O6uWA-0003ed-CF
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 19:48:43 -0400
Received: from mail-gx0-f209.google.com ([209.85.217.209]:49199)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <junkoi2004@gmail.com>) id 1O6uWA-0003eZ-7c
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 19:48:42 -0400
Received: by gxk1 with SMTP id 1so6442556gxk.16
	for <qemu-devel@nongnu.org>; Tue, 27 Apr 2010 16:48:41 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4BD72E96.8050406@web.de>
References: <z2jfdaac4d51004262025o432d94f2xe474e09efd1fd634@mail.gmail.com>
	<4BD72E96.8050406@web.de>
From: Jun Koi <junkoi2004@gmail.com>
Date: Wed, 28 Apr 2010 08:48:21 +0900
Message-ID: <z2vfdaac4d51004271648o546db75z9b6d2cbddab8b92b@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org

On Wed, Apr 28, 2010 at 3:36 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
> Jun Koi wrote:
>> It is not necessary to continue searching for watchpoint when we
>> already found one and setup for handling watchpoint in a search loop
>> in tlb_set_page().
>> This patch breaks that search loop on then.
>
> Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
>
>>
>> Signed-off-by: Jun Koi <junkoi2004@gmail.com>
>>
>> diff --git a/exec.c b/exec.c
>> index 14d1fd7..6329775 100644
>> --- a/exec.c
>> +++ b/exec.c
>> @@ -2240,6 +2240,7 @@ void tlb_set_page(CPUState *env, target_ulong vadd=
r,
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0/* TODO: The memory case can be optimized by =
not trapping
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reads of pages with a write breakpoint. =
=A0*/
>
> PS: Don't you also want to address this todo while you are at it? :)
>

OK, I will look at that in my little spare time.

Thanks,
J