From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: "Volker Rü melin" <vr_qemu@t-online.de>, qemu-devel@nongnu.org
Cc: "Igor Skalkin" <Igor.Skalkin@opensynergy.com>,
"Anton Yakovlev" <Anton.Yakovlev@opensynergy.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"ichael S. Tsirkin" <mst@redhat.com>,
"Daniel P. Berrangé " <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Alex Benné e" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé " <philmd@linaro.org>
Subject: Re: [PATCH v6 01/12] Add virtio-sound device stub
Date: Mon, 21 Aug 2023 09:06:27 +0300 [thread overview]
Message-ID: <zq93g.y1gwybb8v8l9@linaro.org> (raw)
In-Reply-To: <f49650d9-f80f-bbbe-1c0a-4a42a6c6ec76@t-online.de>
Hello Volker!
On Sun, 20 Aug 2023 12:33, Volker Rümelin <vr_qemu@t-online.de> wrote:
>I think the virtio-snd.c code, the trace events and the Kconfig
>VIRTIO_SND should be moved to hw/audio. The code for nearly all audio
>devices is in this directory. This would be similar to other virtio
>devices. E.g. the virtio-scsi code is in hw/scsi and the virtio-net
>code is in hw/net.
This was where it was initially but in previous patchset versions it was
recommended to move them to hw/virtio. I don't mind either approach
though.
Manos
next prev parent reply other threads:[~2023-08-21 6:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 9:07 [PATCH v6 00/12] Add VIRTIO sound card Emmanouil Pitsidianakis
2023-08-15 9:07 ` [PATCH v6 01/12] Add virtio-sound device stub Emmanouil Pitsidianakis
2023-08-20 9:33 ` Volker Rümelin
2023-08-21 6:06 ` Manos Pitsidianakis [this message]
2023-08-21 18:52 ` Volker Rümelin
2023-08-22 8:46 ` Alex Bennée
2023-08-15 9:07 ` [PATCH v6 02/12] Add virtio-sound-pci device Emmanouil Pitsidianakis
2023-08-20 9:08 ` Volker Rümelin
2023-08-15 9:07 ` [PATCH v6 03/12] virtio-sound: handle control messages and streams Emmanouil Pitsidianakis
2023-08-15 9:07 ` [PATCH v6 04/12] virtio-sound: set PCM stream parameters Emmanouil Pitsidianakis
2023-08-15 9:07 ` [PATCH v6 05/12] virtio-sound: handle VIRTIO_SND_R_PCM_INFO request Emmanouil Pitsidianakis
2023-08-15 9:07 ` [PATCH v6 06/12] virtio-sound: handle VIRTIO_SND_R_PCM_{START,STOP} Emmanouil Pitsidianakis
2023-08-15 9:07 ` [PATCH v6 07/12] virtio-sound: handle VIRTIO_SND_PCM_SET_PARAMS Emmanouil Pitsidianakis
2023-08-15 9:07 ` [PATCH v6 08/12] virtio-sound: handle VIRTIO_SND_R_PCM_PREPARE Emmanouil Pitsidianakis
2023-08-15 9:07 ` [PATCH v6 09/12] virtio-sound: handle VIRTIO_SND_PCM_RELEASE Emmanouil Pitsidianakis
2023-08-15 9:07 ` [PATCH v6 10/12] virtio-sound: implement audio output (TX) Emmanouil Pitsidianakis
2023-08-15 9:07 ` [PATCH v6 11/12] virtio-sound: implement audio capture (RX) Emmanouil Pitsidianakis
2023-08-15 15:04 ` 林伟6
2023-08-15 9:07 ` [PATCH v6 12/12] docs/system: add basic virtio-snd documentation Emmanouil Pitsidianakis
2023-08-20 11:46 ` [PATCH v6 00/12] Add VIRTIO sound card Volker Rümelin
2023-08-21 6:10 ` Manos Pitsidianakis
2023-08-21 19:35 ` Volker Rümelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=zq93g.y1gwybb8v8l9@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=Anton.Yakovlev@opensynergy.com \
--cc=Igor.Skalkin@opensynergy.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).