From: Paul Durrant <xadimgnik@gmail.com>
To: "'Eduardo Habkost'" <ehabkost@redhat.com>, <qemu-devel@nongnu.org>
Cc: "'Paolo Bonzini'" <pbonzini@redhat.com>,
"'Daniel P. Berrange'" <berrange@redhat.com>,
"'Marc-André Lureau'" <marcandre.lureau@redhat.com>,
"'Gerd Hoffmann'" <kraxel@redhat.com>,
"'Michael S. Tsirkin'" <mst@redhat.com>,
"'Peter Maydell'" <peter.maydell@linaro.org>,
"'Corey Minyard'" <cminyard@mvista.com>,
"'Cédric Le Goater'" <clg@kaod.org>,
"'David Gibson'" <david@gibson.dropbear.id.au>,
"'Cornelia Huck'" <cohuck@redhat.com>,
"'Thomas Huth'" <thuth@redhat.com>,
"'Halil Pasic'" <pasic@linux.ibm.com>,
"'Christian Borntraeger'" <borntraeger@de.ibm.com>,
"'Philippe Mathieu-Daudé'" <f4bug@amsat.org>,
"'Alistair Francis'" <alistair@alistair23.me>,
"'David Hildenbrand'" <david@redhat.com>,
"'Laurent Vivier'" <lvivier@redhat.com>,
"'Amit Shah'" <amit@kernel.org>,
"'Stefano Stabellini'" <sstabellini@kernel.org>,
"'Anthony Perard'" <anthony.perard@citrix.com>,
"'Fam Zheng'" <fam@euphon.net>,
"'Gonglei (Arei)'" <arei.gonglei@huawei.com>,
"'Igor Mammedov'" <imammedo@redhat.com>,
"'Stefan Berger'" <stefanb@linux.ibm.com>,
"'Richard Henderson'" <rth@twiddle.net>,
"'Michael Rolnik'" <mrolnik@gmail.com>,
"'Sarah Harris'" <S.E.Harris@kent.ac.uk>,
"'Edgar E. Iglesias'" <edgar.iglesias@gmail.com>,
"'Michael Walle'" <michael@walle.cc>,
"'Aleksandar Markovic'" <aleksandar.qemu.devel@gmail.com>,
"'Aurelien Jarno'" <aurelien@aurel32.net>,
"'Jiaxun Yang'" <jiaxun.yang@flygoat.com>,
"'Aleksandar Rikalo'" <aleksandar.rikalo@syrmia.com>,
"'Anthony Green'" <green@moxielogic.com>,
"'Chris Wulff'" <crwulff@gmail.com>,
"'Marek Vasut'" <marex@denx.de>,
"'Stafford Horne'" <shorne@gmail.com>,
"'Palmer Dabbelt'" <palmer@dabbelt.com>,
"'Sagar Karandikar'" <sagark@eecs.berkeley.edu>,
"'Bastian Koppelmann'" <kbastian@mail.uni-paderborn.de>,
"'Yoshinori Sato'" <ysato@users.sourceforge.jp>,
"'Mark Cave-Ayland'" <mark.cave-ayland@ilande.co.uk>,
"'Artyom Tarasenko'" <atar4qemu@gmail.com>,
"'Guan Xuetao'" <gxt@mprc.pku.edu.cn>,
"'Max Filippov'" <jcmvbkbc@gmail.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org,
qemu-block@nongnu.org, xen-devel@lists.xenproject.org,
qemu-riscv@nongnu.org
Subject: RE: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros
Date: Thu, 17 Sep 2020 08:57:33 +0100 [thread overview]
Message-ID: <007c01d68cc8$347614f0$9d623ed0$@xen.org> (raw)
In-Reply-To: <20200916182519.415636-4-ehabkost@redhat.com>
> -----Original Message-----
> From: Eduardo Habkost <ehabkost@redhat.com>
> Sent: 16 September 2020 19:25
> To: qemu-devel@nongnu.org
> Cc: Paolo Bonzini <pbonzini@redhat.com>; Daniel P. Berrange <berrange@redhat.com>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Gerd Hoffmann <kraxel@redhat.com>; Michael S. Tsirkin <mst@redhat.com>;
> Peter Maydell <peter.maydell@linaro.org>; Corey Minyard <cminyard@mvista.com>; Cédric Le Goater
> <clg@kaod.org>; David Gibson <david@gibson.dropbear.id.au>; Cornelia Huck <cohuck@redhat.com>; Thomas
> Huth <thuth@redhat.com>; Halil Pasic <pasic@linux.ibm.com>; Christian Borntraeger
> <borntraeger@de.ibm.com>; Philippe Mathieu-Daudé <f4bug@amsat.org>; Alistair Francis
> <alistair@alistair23.me>; David Hildenbrand <david@redhat.com>; Laurent Vivier <lvivier@redhat.com>;
> Amit Shah <amit@kernel.org>; Stefano Stabellini <sstabellini@kernel.org>; Anthony Perard
> <anthony.perard@citrix.com>; Paul Durrant <paul@xen.org>; Fam Zheng <fam@euphon.net>; Gonglei (Arei)
> <arei.gonglei@huawei.com>; Igor Mammedov <imammedo@redhat.com>; Stefan Berger <stefanb@linux.ibm.com>;
> Richard Henderson <rth@twiddle.net>; Michael Rolnik <mrolnik@gmail.com>; Sarah Harris
> <S.E.Harris@kent.ac.uk>; Edgar E. Iglesias <edgar.iglesias@gmail.com>; Michael Walle
> <michael@walle.cc>; Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>; Aurelien Jarno
> <aurelien@aurel32.net>; Jiaxun Yang <jiaxun.yang@flygoat.com>; Aleksandar Rikalo
> <aleksandar.rikalo@syrmia.com>; Anthony Green <green@moxielogic.com>; Chris Wulff <crwulff@gmail.com>;
> Marek Vasut <marex@denx.de>; Stafford Horne <shorne@gmail.com>; Palmer Dabbelt <palmer@dabbelt.com>;
> Sagar Karandikar <sagark@eecs.berkeley.edu>; Bastian Koppelmann <kbastian@mail.uni-paderborn.de>;
> Yoshinori Sato <ysato@users.sourceforge.jp>; Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>; Artyom
> Tarasenko <atar4qemu@gmail.com>; Guan Xuetao <gxt@mprc.pku.edu.cn>; Max Filippov <jcmvbkbc@gmail.com>;
> qemu-arm@nongnu.org; qemu-ppc@nongnu.org; qemu-s390x@nongnu.org; qemu-block@nongnu.org; xen-
> devel@lists.xenproject.org; qemu-riscv@nongnu.org
> Subject: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros
>
> One of the goals of having less boilerplate on QOM declarations
> is to avoid human error. Requiring an extra argument that is
> never used is an opportunity for mistakes.
>
> Remove the unused argument from OBJECT_DECLARE_TYPE and
> OBJECT_DECLARE_SIMPLE_TYPE.
>
> Coccinelle patch used to convert all users of the macros:
>
> @@
> declarer name OBJECT_DECLARE_TYPE;
> identifier InstanceType, ClassType, lowercase, UPPERCASE;
> @@
> OBJECT_DECLARE_TYPE(InstanceType, ClassType,
> - lowercase,
> UPPERCASE);
>
> @@
> declarer name OBJECT_DECLARE_SIMPLE_TYPE;
> identifier InstanceType, lowercase, UPPERCASE;
> @@
> OBJECT_DECLARE_SIMPLE_TYPE(InstanceType,
> - lowercase,
> UPPERCASE);
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Paul Durrant <paul@xen.org>
next prev parent reply other threads:[~2020-09-17 7:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200916182519.415636-1-ehabkost@redhat.com>
2020-09-16 18:25 ` [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros Eduardo Habkost
2020-09-17 6:53 ` Thomas Huth
2020-09-17 7:11 ` Igor Mammedov
2020-09-17 7:42 ` Cédric Le Goater
2020-09-17 7:46 ` Cornelia Huck
2020-09-17 7:57 ` Paul Durrant [this message]
2020-09-16 18:25 ` [PATCH 5/5] [automated] Use OBJECT_DECLARE_SIMPLE_TYPE when possible Eduardo Habkost
2020-09-17 7:57 ` Paul Durrant
2020-09-18 18:17 ` [PATCH 0/5] qom: Convert more declarations to OBJECT_DECLARE* Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007c01d68cc8$347614f0$9d623ed0$@xen.org' \
--to=xadimgnik@gmail.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alistair@alistair23.me \
--cc=amit@kernel.org \
--cc=anthony.perard@citrix.com \
--cc=arei.gonglei@huawei.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=clg@kaod.org \
--cc=cminyard@mvista.com \
--cc=cohuck@redhat.com \
--cc=crwulff@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=imammedo@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=mrolnik@gmail.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=shorne@gmail.com \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).