From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B09B7CAC5BB for ; Wed, 1 Oct 2025 16:24:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3zcP-0000nK-JX; Wed, 01 Oct 2025 12:23:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3zcO-0000m9-4N for qemu-riscv@nongnu.org; Wed, 01 Oct 2025 12:23:52 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v3zcC-0005kD-1Y for qemu-riscv@nongnu.org; Wed, 01 Oct 2025 12:23:51 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-46e504975dbso30094605e9.1 for ; Wed, 01 Oct 2025 09:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759335811; x=1759940611; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VsyErOj0C4qTR0dhaSEh2ia15dVXw2WZRvV5/OWw62I=; b=Rp2+eXDETiO4RXtuEAbadvQ3UXRjyTJFfKQVPCNChl14wpSgpURAoRyz+XvOdk5lng 8/UY0wy1fUA12ILNY9K3ZD8KC6N+83VeANd7CYUNLqc63I2X3VuuOPJEIyodq8XcAIGB sn/FHvWLTiUoGcIjE8lQVmZZ8TRGC6GQEV+1u55fxq2X7m5XlZhMn7Y5tGvdzqQQSKYU pJzXHllHcnTw/wyT2cYo0HBXxBCj2UGsXtLqkTbV2AMLf3l2Foa26ATIrxlqeRYrdH8X zA3Z4mkrzmIG02eP8IZjjpkBH5GGYChMZTrFsuQDC84YAlN1EiKhgpTEy+RO7dofHm04 5o6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759335811; x=1759940611; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VsyErOj0C4qTR0dhaSEh2ia15dVXw2WZRvV5/OWw62I=; b=wa8WkILfKuXKc7KATcyfigdSw9EDHFktcVSsdaDAd+Lu9tti+BGhPsloE6aeiCu7uY +lZCPVnEByc1EdkJEqh3udXG3K6BzeZ0vGkXT7ec13xtYA/t2yUjTMSuIhEHIwIAhiny 3R2mDZCZfK8ItkQO1BzbBFpdA3RWgczROhnfe2sZewQj8sC7/PfmrBtHJTpTwVh6imHm eHWoFmtuIn05j8+NO4UuVAMdKPENMu8eJNGYHMwlAEySmksqYPxWrE9g9hs3+LwWH+GY hlabacKXcvDcu0rnWlQX7WLoFBgnPZL6PhJ9R6Vuxj2fJkQYIydBZbl8kRD2WBML73fC vXJA== X-Forwarded-Encrypted: i=1; AJvYcCUCyOfwr9hw2x8djt8Yof//hLJDT2rfAKWsHiakqayCIL7QmRbfBjODZGPyzQ3NLTor1i9Wfo1qAJtx@nongnu.org X-Gm-Message-State: AOJu0YxEnuxq1OsJKD/eV9lMReySyHLE0vp8a3FujGBo7Ej0VJy0OTLd fp74VG+Md6ol8xR7aQcqQ2eHWR2WBAqnkqCH64AMZNsbP7Qn+X7bo+seYhp46ybrzi8= X-Gm-Gg: ASbGncst8QQZg+CaHScuvBAZo5T8nW/RMAJGznfrWk3C86cFkj6Bh82YKSH4REExbe+ zqCIsFLum+eaC65eFnPuDMvx4xIV2rPeA098Fs2iaJhF6pG1xIhh2bCDpw4hUOCtq9lGytU+0rw lpWPFi1x6YeeVdF4APop+QjiCtUdJUnUSivpD4WDcCdsKcykoTYUKH7LTXJIn0zLxwYxW4Vpd65 qf6/ejtcT7imkUEuitUmjCTCQ1w9fqsNKOSGnr7qlvDYqaEPPlgJHuLTHuXgkA6GpAswIJCLO3b Loj0jdB4HbEMSjK2r817h/efnCU0CDSnGbLWn2l1cLU5VFndjwLmuYnXjL0DAFaCE8EZASAuCKX dUMOHe1flTkC23d3KfjgpoR4Xj6QzCkeU9DJet4qBQwizn4ZNbxw2gqrihADNy/3v0Sl5IblWsV Eiqz8NWT8wVN5xlw== X-Google-Smtp-Source: AGHT+IHeoZu0ymi8Pfk0X0YHUUowtYfUT6O7ZFYxwRepAEs318Ow0exFrX3Q4sJq+PIpUItFz2JAAg== X-Received: by 2002:a05:600c:c4a4:b0:46d:996b:826f with SMTP id 5b1f17b1804b1-46e612dcfd0mr38375745e9.25.1759335811038; Wed, 01 Oct 2025 09:23:31 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e619b86e1sm44201225e9.5.2025.10.01.09.23.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 09:23:30 -0700 (PDT) Message-ID: <0c60b6e7-9e87-49aa-b00b-751c038ab8fa@linaro.org> Date: Wed, 1 Oct 2025 18:23:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/22] monitor/hmp-cmds: Get cpu first addr space with cpu_get_address_space() To: BALATON Zoltan Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-s390x@nongnu.org, Richard Henderson , qemu-riscv@nongnu.org, Peter Maydell , qemu-ppc@nongnu.org, Paolo Bonzini , Pierrick Bouvier , Peter Xu , "Dr. David Alan Gilbert" References: <20251001150529.14122-1-philmd@linaro.org> <20251001150529.14122-4-philmd@linaro.org> <2b87c3ee-2b25-bea5-3f73-bd089848d19e@eik.bme.hu> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <2b87c3ee-2b25-bea5-3f73-bd089848d19e@eik.bme.hu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 1/10/25 17:35, BALATON Zoltan wrote: > On Wed, 1 Oct 2025, Philippe Mathieu-Daudé wrote: >> In order to remove the convenient CPUState::as field, access >> the vcpu first address space using the cpu_get_address_space() >> helper. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> monitor/hmp-cmds-target.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c >> index e9820611466..602af851328 100644 >> --- a/monitor/hmp-cmds-target.c >> +++ b/monitor/hmp-cmds-target.c >> @@ -128,6 +128,8 @@ static void memory_dump(Monitor *mon, int count, >> int format, int wsize, >>     uint8_t buf[16]; >>     uint64_t v; >>     CPUState *cs = mon_get_cpu(mon); >> +    AddressSpace *as = cs ? cpu_get_address_space(cs, 0) >> +                          : &address_space_memory; > > Why move from local scope to an upper level? Out of the while() loop to call it once only. > > Regards, > BALATON Zoltan > >>     if (!cs && (format == 'i' || !is_physical)) { >>         monitor_printf(mon, "Can not dump without CPU\n"); >> @@ -174,7 +176,6 @@ static void memory_dump(Monitor *mon, int count, >> int format, int wsize, >>         if (l > line_size) >>             l = line_size; >>         if (is_physical) { >> -            AddressSpace *as = cs ? cs->as : &address_space_memory; >>             MemTxResult r = address_space_read(as, addr, >>                                                MEMTXATTRS_UNSPECIFIED, >> buf, l); >>             if (r != MEMTX_OK) { >>