qemu-riscv.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
	qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com,
	bmeng@tinylab.org, liwei1518@gmail.com,
	zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com
Subject: Re: [PATCH 3/7] hw/riscv/virt.c: use g_autofree in create_fdt_socket_cpus()
Date: Tue, 23 Jan 2024 06:42:47 +0100	[thread overview]
Message-ID: <144fc09e-fa3c-4a6d-a724-a46e434fc5f8@linaro.org> (raw)
In-Reply-To: <20240122221529.86562-4-dbarboza@ventanamicro.com>

On 22/1/24 23:15, Daniel Henrique Barboza wrote:
> Move all char pointers to the loop. Use g_autofree in all of them to
> avoid the g_free() calls.
> 
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
>   hw/riscv/virt.c | 12 +++++-------
>   1 file changed, 5 insertions(+), 7 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2024-01-23  5:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 22:15 [PATCH 0/7] hw/riscv: fix leak, add more g_autofree Daniel Henrique Barboza
2024-01-22 22:15 ` [PATCH 1/7] hw/riscv/virt-acpi-build.c: fix leak in build_rhct() Daniel Henrique Barboza
2024-02-05  2:57   ` Alistair Francis
2024-01-22 22:15 ` [PATCH 2/7] hw/riscv/numa.c: use g_autofree in socket_fdt_write_distance_matrix() Daniel Henrique Barboza
2024-02-05  2:57   ` Alistair Francis
2024-01-22 22:15 ` [PATCH 3/7] hw/riscv/virt.c: use g_autofree in create_fdt_socket_cpus() Daniel Henrique Barboza
2024-01-23  5:42   ` Philippe Mathieu-Daudé [this message]
2024-02-05  2:58   ` Alistair Francis
2024-01-22 22:15 ` [PATCH 4/7] hw/riscv/virt.c: use g_autofree in create_fdt_sockets() Daniel Henrique Barboza
2024-02-05  2:59   ` Alistair Francis
2024-01-22 22:15 ` [PATCH 5/7] hw/riscv/virt.c: use g_autofree in create_fdt_virtio() Daniel Henrique Barboza
2024-01-23  5:43   ` Philippe Mathieu-Daudé
2024-02-05  3:00   ` Alistair Francis
2024-01-22 22:15 ` [PATCH 6/7] hw/riscv/virt.c: use g_autofree in virt_machine_init() Daniel Henrique Barboza
2024-01-23  5:44   ` Philippe Mathieu-Daudé
2024-02-05  3:00   ` Alistair Francis
2024-01-22 22:15 ` [PATCH 7/7] hw/riscv/virt.c: use g_autofree in create_fdt_* Daniel Henrique Barboza
2024-02-05  3:02   ` Alistair Francis
2024-02-05  3:16 ` [PATCH 0/7] hw/riscv: fix leak, add more g_autofree Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=144fc09e-fa3c-4a6d-a724-a46e434fc5f8@linaro.org \
    --to=philmd@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=bmeng@tinylab.org \
    --cc=dbarboza@ventanamicro.com \
    --cc=liwei1518@gmail.com \
    --cc=palmer@rivosinc.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).