From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j04M1-0003JG-CE for mharc-qemu-riscv@gnu.org; Fri, 07 Feb 2020 09:11:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46380) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j04Lx-0003Fe-In for qemu-riscv@nongnu.org; Fri, 07 Feb 2020 09:11:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j04Lw-0003N2-Ha for qemu-riscv@nongnu.org; Fri, 07 Feb 2020 09:11:29 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:26592 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j04Lw-0003Lf-DS for qemu-riscv@nongnu.org; Fri, 07 Feb 2020 09:11:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581084687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o81+JWmLU/tFz7R4cIBaX3fO8pUbp9JTZdiL9GKDwS8=; b=YyRol/tngp4sph/BUE0LTmtt5PjcOPzWccZgigURuc6O7a4ksKapiChUuAuxabDLtNfhUn x3VqkQSJtKiTrM07jW4IjIsaC0nQm5zrtsT7obHiUjYsVxzaV2H0ZYBZr11xzkkDawwsZu eGF+b1sWLEmq6Vk2nA0sPvoRWZi0c+Y= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-PK0IWXl5M42XlNjxmZWVng-1; Fri, 07 Feb 2020 09:11:25 -0500 Received: by mail-qt1-f199.google.com with SMTP id x8so1650133qtq.14 for ; Fri, 07 Feb 2020 06:11:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=r7HLC+pRyHdtI1HUnYeCh7nUdsYVlBwhAa0vgrpGZwE=; b=hz9CHY9dviEnSqSiBr27PpSPegxwwmjcy3LbAU4BdryJyTqQsl0mfDU4wux0OMoOsb 955SK+puZI8QqaaIEIBtTJzUiCNnD5wwaXCD2nhdf8rogb1hR0iWrSbmOIwTGrXpA7g2 SFNfmK8fI6OMdy8Wjhoni/3EDJb/FI+tJ4jzUyY5xyTIbJSmIGg9b+ugRFonIc4t1KsN AgZ85qlTDFKYiRjDHgrGR+OWN+aDZFVCdw5cmI6DnYDz99nq/jqawqGqmqiK1fN7Tq1N Ct7m/fiqko+Z5qho74hbhuMWSG9yxJ7PpInjuIImpIoeDFniQ3JL+Q7nRnmqkhjWAVlB iJDw== X-Gm-Message-State: APjAAAVA2rDOMtYn2oDSau4UVjqPCQpaa+Nxm6rblgAIjtkHmWbjlUll rRsXFyVIrWWTqwDqbV+GPoza7mdKiVPQijUes6F9l+cl3iakm7gdoQ3tBw/vNAOkNyIen8e7T85 NM5BVlloFkDI8QMY= X-Received: by 2002:ae9:f50c:: with SMTP id o12mr7535343qkg.42.1581084685173; Fri, 07 Feb 2020 06:11:25 -0800 (PST) X-Google-Smtp-Source: APXvYqybFpSe7hEw7HPlsSHWTeTred/Bqbnh34A8vvhVkNG91NbRJEbUtCucDkm6pF0Z6PlJOt/FQw== X-Received: by 2002:ae9:f50c:: with SMTP id o12mr7535300qkg.42.1581084684907; Fri, 07 Feb 2020 06:11:24 -0800 (PST) Received: from redhat.com (bzq-79-176-41-183.red.bezeqint.net. [79.176.41.183]) by smtp.gmail.com with ESMTPSA id d17sm1358069qkc.9.2020.02.07.06.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2020 06:11:24 -0800 (PST) Date: Fri, 7 Feb 2020 09:11:15 -0500 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Alistair Francis , Aurelien Jarno , qemu-trivial@nongnu.org, Richard Henderson , Anthony Green , Christian Borntraeger , Guan Xuetao , Mark Cave-Ayland , Richard Henderson , Aleksandar Markovic , Aleksandar Rikalo , Stafford Horne , David Gibson , Sagar Karandikar , Michael Walle , Marcel Apfelbaum , Chris Wulff , qemu-s390x@nongnu.org, Cornelia Huck , David Hildenbrand , Halil Pasic , Helge Deller , Artyom Tarasenko , Bastian Koppelmann , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, Marek Vasut , Jia Liu , "Edgar E. Iglesias" , Eduardo Habkost , Paolo Bonzini , Laurent Vivier , Palmer Dabbelt , Thomas Huth , Magnus Damm , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Subject: Re: [PATCH v3 3/3] vl: Abort if multiple machines are registered as default Message-ID: <20200207090427-mutt-send-email-mst@kernel.org> References: <20200207130453.16666-1-philmd@redhat.com> <20200207130453.16666-4-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200207130453.16666-4-philmd@redhat.com> X-MC-Unique: PK0IWXl5M42XlNjxmZWVng-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Feb 2020 14:11:31 -0000 On Fri, Feb 07, 2020 at 02:04:53PM +0100, Philippe Mathieu-Daud=E9 wrote: > It would be confusing to have multiple default machines. > Abort if this ever occurs. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > v2: Use assert() instead of human friendly message (Marc-Andr=E9) >=20 > Cc: Marc-Andr=E9 Lureau > Cc: Laurent Vivier Is it really worth adding counting logic just so we can assert? There are a bunch of other places that deal with default, like qmp query machines and find_default_machine. > --- > vl.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/vl.c b/vl.c > index 7dcb0879c4..b3e0f7af25 100644 > --- a/vl.c > +++ b/vl.c > @@ -2354,6 +2354,8 @@ static MachineClass *machine_parse(const char *name= , GSList *machines) > GSList *el; > =20 > if (is_help_option(name)) { > + int default_count =3D 0; > + > printf("Supported machines are:\n"); > machines =3D g_slist_sort(machines, machine_class_cmp); > for (el =3D machines; el; el =3D el->next) { > @@ -2364,7 +2366,9 @@ static MachineClass *machine_parse(const char *name= , GSList *machines) > printf("%-20s %s%s%s\n", mc->name, mc->desc, > mc->is_default ? " (default)" : "", > mc->deprecation_reason ? " (deprecated)" : ""); > + default_count +=3D !!mc->is_default; > } > + assert(default_count <=3D 1); > exit(0); > } > =20 > --=20 > 2.21.1