From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90D0AC47DDF for ; Sun, 28 Jan 2024 08:28:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rU0WB-0004VA-7f; Sun, 28 Jan 2024 03:27:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rU0W9-0004UN-2K for qemu-riscv@nongnu.org; Sun, 28 Jan 2024 03:27:53 -0500 Received: from mail-oo1-xc2d.google.com ([2607:f8b0:4864:20::c2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rU0W7-0007Bw-5X for qemu-riscv@nongnu.org; Sun, 28 Jan 2024 03:27:52 -0500 Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-595d24ad466so1337853eaf.0 for ; Sun, 28 Jan 2024 00:27:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1706430469; x=1707035269; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GbHsFPTqeVEF6MXxcuYOrP3CMgZR2bO4xbc3tDD6CnQ=; b=3Y6CtntcA0yFrHNQnT2LA/Fzjjt20bNi4YveUeAWHkDTwqmyM2xXPGDuaFs4/XOM57 m7POFwd9Ro2uhoFj0J1gAVIk0Qa+SK00Qtaz2xOwI5P8Rl+12LQh+T9zk/TCJy+LzMvG 97DkcB8Ixvg3IYacQ2dS+J1MLi9C8BUIsmnwNd3iK2EsErnuBrZUu9GzqnGqOzvKIUAh 5gAdA6dsun0Cr64Z2fGKwPGsmPBYrf1ASdbNL5BipiVlNYHLZgsadWdcoo0Yuvi/gtnB xOHm0IVK+/cGmLzTWi+5hnFn9EBp/+GbmWLMQ8uTwKwJb+MEAqqV3Gq4aBUTQyhvc59C a3rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706430469; x=1707035269; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GbHsFPTqeVEF6MXxcuYOrP3CMgZR2bO4xbc3tDD6CnQ=; b=bfhpyWL9Kf1byKJfjqRdF0UnDC6VdVciNi/yQ6q65fkPIj9Pni2qw2Z9fBdkvJ7PZS 0C+hJhXvtvld7jyTxypa8YqRkfT+eBUZ0UtaMfGLMb1vDY1KmbYAM9VkaZsIWqSzxWt5 fualm7wE3MqBEgOd9vGIJuapv1hBcdRsBHi29pk033uIhD0BCdby0tpGyBTIAcegebgk +WgJaURm3vbxL8VuFLHWBTHdekxhXUp8THaISbl7rmkREddmxWng+z811Ffjlo/SfgXk 6VlqbULpkeCU3iZaCRsdwINNsizon2Vl23e+ZJ7qdADIKyL/4d5VDHD/DjINa+rs+tOH NxYQ== X-Gm-Message-State: AOJu0YyX2QsLQahIjuVdRjpHyhBiulnnLIsGmZa09mMteD3YsEhaPd2R J3iNW/NuXt5CR8mkUmWvh/1V6diDeEpW/t/STIf/SE3sIlgDDdJJgJavT2aLxl4= X-Google-Smtp-Source: AGHT+IEfmEKZ2dtXCEvBt0zHlBdn0Xzoval3PyAYgAhrJPMsgazE03lMFcaQ7Pwvcvx/9gIzD6BTsg== X-Received: by 2002:a05:6358:7e0e:b0:176:d451:97d8 with SMTP id o14-20020a0563587e0e00b00176d45197d8mr3379005rwm.51.1706430469399; Sun, 28 Jan 2024 00:27:49 -0800 (PST) Received: from localhost ([157.82.200.138]) by smtp.gmail.com with UTF8SMTPSA id e7-20020aa79807000000b006da96503d9fsm3789106pfl.109.2024.01.28.00.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jan 2024 00:27:49 -0800 (PST) From: Akihiko Odaki Date: Sun, 28 Jan 2024 17:27:39 +0900 Subject: [PATCH v10 1/3] target/riscv: Remove misa_mxl validation MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240128-riscv-v10-1-fdbe593976e9@daynix.com> References: <20240128-riscv-v10-0-fdbe593976e9@daynix.com> In-Reply-To: <20240128-riscv-v10-0-fdbe593976e9@daynix.com> To: Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , =?utf-8?q?Alex_Benn=C3=A9e?= , Mikhail Tyutin , Aleksandr Anenkov , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , Andrew Jones Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Akihiko Odaki X-Mailer: b4 0.12.3 Received-SPF: none client-ip=2607:f8b0:4864:20::c2d; envelope-from=akihiko.odaki@daynix.com; helo=mail-oo1-xc2d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org It is initialized with a simple assignment and there is little room for error. In fact, the validation is even more complex. Signed-off-by: Akihiko Odaki Acked-by: LIU Zhiwei Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis --- target/riscv/tcg/tcg-cpu.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/target/riscv/tcg/tcg-cpu.c b/target/riscv/tcg/tcg-cpu.c index 14133ff66568..b85b0d036a61 100644 --- a/target/riscv/tcg/tcg-cpu.c +++ b/target/riscv/tcg/tcg-cpu.c @@ -268,7 +268,7 @@ static void riscv_cpu_validate_misa_priv(CPURISCVState *env, Error **errp) } } -static void riscv_cpu_validate_misa_mxl(RISCVCPU *cpu, Error **errp) +static void riscv_cpu_validate_misa_mxl(RISCVCPU *cpu) { RISCVCPUClass *mcc = RISCV_CPU_GET_CLASS(cpu); CPUClass *cc = CPU_CLASS(mcc); @@ -288,11 +288,6 @@ static void riscv_cpu_validate_misa_mxl(RISCVCPU *cpu, Error **errp) default: g_assert_not_reached(); } - - if (env->misa_mxl_max != env->misa_mxl) { - error_setg(errp, "misa_mxl_max must be equal to misa_mxl"); - return; - } } static void riscv_cpu_validate_priv_spec(RISCVCPU *cpu, Error **errp) @@ -932,7 +927,6 @@ static bool riscv_cpu_is_vendor(Object *cpu_obj) static bool tcg_cpu_realize(CPUState *cs, Error **errp) { RISCVCPU *cpu = RISCV_CPU(cs); - Error *local_err = NULL; if (!riscv_cpu_tcg_compatible(cpu)) { g_autofree char *name = riscv_cpu_get_name(cpu); @@ -941,14 +935,11 @@ static bool tcg_cpu_realize(CPUState *cs, Error **errp) return false; } - riscv_cpu_validate_misa_mxl(cpu, &local_err); - if (local_err != NULL) { - error_propagate(errp, local_err); - return false; - } + riscv_cpu_validate_misa_mxl(cpu); #ifndef CONFIG_USER_ONLY CPURISCVState *env = &cpu->env; + Error *local_err = NULL; CPU(cs)->tcg_cflags |= CF_PCREL; -- 2.43.0