From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C83F4CCF9EA for ; Mon, 27 Oct 2025 11:07:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDL1z-00010b-5y; Mon, 27 Oct 2025 07:04:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDL1O-0000cy-Un for qemu-riscv@nongnu.org; Mon, 27 Oct 2025 07:04:19 -0400 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vDL1I-0005i4-8u for qemu-riscv@nongnu.org; Mon, 27 Oct 2025 07:04:15 -0400 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-b6d855ca585so469894566b.0 for ; Mon, 27 Oct 2025 04:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761563041; x=1762167841; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UQ3rv8bxHo1Z+FZ1pDBdGd57of56T+KuUG/sJxnyepk=; b=E8QbNApzRX87R78v1piAbPnvtoTxUKUGfY8RstoqmhbHAMq7zG4Y7GWcK5BXww0wBV u2m1G7AMGjM+Qd+TWeYyFDNHLyK9r63fH5ia3NoLkxpFs60ugkHqcy9Eh4Z74tcGtjdw 06qClOnqQMXIbvxN7qr599xGW8DP5N6x0ftSTJV+oMmTeUfWc74XjdOaf5+uwWFsSJln NXKqTanJ8MnCABoIQpY043+dZD1JRc/qPtO2NiU+dccz3P5xvGKoNTmiWyOM8IGrnSp4 KqZb4OMfMNb2PZfT9MPThVMaObS2eUU06XXZCIwoeTKSs6cDw+SVhxa3hvQgUCEnkDm/ q++A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761563041; x=1762167841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UQ3rv8bxHo1Z+FZ1pDBdGd57of56T+KuUG/sJxnyepk=; b=WpmBSMdxZCDwtF12Zs75o9e72t0RmIlE6UyHmdGUgEE6SqbpKE4dq3Oh460N23Jymz 2wvpUVLvA4p/oCj3cuMUrkvYAYYdIapPzCxUKD9TAeBKsaaPxRn0hSbvrjQBCRh96DuA rP1cnc7PzWO38xHytdARWOcxpB1mQEzpggOm9jOvHXuqkL2/ljcGH6SqjRyje+I22Q0q gBM4kazKONGn0Sjgl00hfu/A9LmZGXOQhPlJUax8EB4gAwUOTk9D3n1kiNYfOSOZSJRw e8zZo0SskgtTRx/BFz0l2AMy7g94LpSic99o7xcEvfji1Lnd584sJU5iecwodDCIhd1N xGew== X-Forwarded-Encrypted: i=1; AJvYcCUvl0yI6wBT/AcCPbxYAX5+HGBuy0LavyJLbrqc9PtbYzKC6hCycG0o5xbAiPh+fxLn8JIMljUy9DMw@nongnu.org X-Gm-Message-State: AOJu0YyveoFbUbiqT+Z3RWzTsYQzHMnAIFKH5dqF8UbXuwhBIg61lEiV S60iA+RND2bukDykRf9bORILvAlgZ2LymEpRREwnxmAAr6f+GrdR5KVRwgx3in1aTFc= X-Gm-Gg: ASbGncsajViotkb155okrU7zo5UTTDO3eTp78DE5jam1f9iRw7xVS7Xop+1VCykirx+ hvR8yCOrVLsU0I7JHCdRZJsCVUL4StYvl9+rklLYxH/t6tuTE/DHN8y7kVdmUTvZrGUEeXvmmVb c62BS+/mAGvzS+iR5hEVti4WWmFb5waBO6x5Yv+SCenxhOUVrAiQeM6CK9qxw8z5jGFKEuYlDBE Cp9tDk+6bF3wBfjryPGOubvGWtfwZnQjCodfHLKcvMZkUlhAszreE4z9GlatRhpbAB9Ulec9aZR qpF2rSPq6E/o+kaUhVKZJjDAu2r+XJ3zshkmHGbxOE87AFgT35wCfIu7BgU8Pm5xVkR6eWeKGGq OXVkqAQ/3bpPiUs99Dp/j4Lsk4elNk2Bi80Re69sIzhtgI/KsP0PbcneKPgbOabmW0rYAAWUgOk N/ X-Google-Smtp-Source: AGHT+IF46Qy8yzQvt49lqS+UxN4daAAklNmAku3KZC2fFz2V0BgNH+izSW10LphrAJD0r0NqE/Josg== X-Received: by 2002:a17:907:d1e:b0:b3e:8252:cd53 with SMTP id a640c23a62f3a-b64725705e5mr4937210966b.27.1761563041013; Mon, 27 Oct 2025 04:04:01 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b6d8535974asm716499266b.25.2025.10.27.04.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:03:54 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 1268D6150B; Mon, 27 Oct 2025 11:03:47 +0000 (GMT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Liu Zhiwei , Alexandre Iooss , Chinmay Rath , qemu-arm@nongnu.org, Peter Maydell , Nicholas Piggin , Ilya Leoshkevich , David Hildenbrand , qemu-ppc@nongnu.org, Paolo Bonzini , qemu-s390x@nongnu.org, Pierrick Bouvier , Bastian Koppelmann , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stafford Horne , Mahmoud Mandour , Artyom Tarasenko , Eduardo Habkost , Palmer Dabbelt , Alistair Francis , Laurent Vivier , Weiwei Li , Daniel Henrique Barboza , Mark Cave-Ayland , Yoshinori Sato , "Edgar E. Iglesias" , Aurelien Jarno , Richard Henderson , Thomas Huth , Max Filippov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Michael Rolnik , Song Gao , qemu-riscv@nongnu.org, Aleksandar Rikalo , Julian Ganz Subject: [PATCH 31/35] tests: add test with interrupted memory accesses on rv64 Date: Mon, 27 Oct 2025 11:03:38 +0000 Message-ID: <20251027110344.2289945-32-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027110344.2289945-1-alex.bennee@linaro.org> References: <20251027110344.2289945-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org From: Julian Ganz This test aims at catching API misbehaviour w.r.t. the interaction between interrupts and memory accesses, such as the bug fixed in 27f347e6a1d269c533633c812321cabb249eada8 (accel/tcg: also suppress asynchronous IRQs for cpu_io_recompile) Because the condition for triggering misbehaviour may not be deterministic and the cross-section between memory accesses and interrupt handlers may be small, we have to place our trust in large numbers. Instead of guessing/trying an arbitrary, fixed loop-bound, we decided to loop for a fixed amount of real-time. This avoids the test running into a time-out on slower machines while enabling a high number of possible interactions on faster machines. The test program sends a single '.' per 1000000 loads/stores over the serial. This output is not captured, but may be used by developers to gauge the number of possible interactions. Reviewed-by: Daniel Henrique Barboza Signed-off-by: Julian Ganz Signed-off-by: Alex Bennée --- tests/tcg/riscv64/Makefile.softmmu-target | 6 ++ tests/tcg/riscv64/interruptedmemory.S | 97 +++++++++++++++++++++++ 2 files changed, 103 insertions(+) create mode 100644 tests/tcg/riscv64/interruptedmemory.S diff --git a/tests/tcg/riscv64/Makefile.softmmu-target b/tests/tcg/riscv64/Makefile.softmmu-target index d9c0036eb4b..eb1ce6504a0 100644 --- a/tests/tcg/riscv64/Makefile.softmmu-target +++ b/tests/tcg/riscv64/Makefile.softmmu-target @@ -30,5 +30,11 @@ run-plugin-doubletrap: doubletrap $(QEMU) -plugin ../plugins/libdiscons.so -d plugin -D $<.pout \ $(QEMU_OPTS)$<) +EXTRA_RUNS += run-plugin-interruptedmemory +run-plugin-interruptedmemory: interruptedmemory + $(call run-test, $<, \ + $(QEMU) -plugin ../plugins/libdiscons.so -d plugin -D $<.pout \ + $(QEMU_OPTS)$<) + # We don't currently support the multiarch system tests undefine MULTIARCH_TESTS diff --git a/tests/tcg/riscv64/interruptedmemory.S b/tests/tcg/riscv64/interruptedmemory.S new file mode 100644 index 00000000000..cd9073ee314 --- /dev/null +++ b/tests/tcg/riscv64/interruptedmemory.S @@ -0,0 +1,97 @@ + .option norvc + + .text + .global _start +_start: + # Set up trap vector + lla t0, trap + csrw mtvec, t0 + + # Set up timer + lui t1, 0x02004 + sd zero, 0(t1) # MTIMECMP0 + + # Enable timer interrupts + li t0, 0x80 + csrrs zero, mie, t0 + csrrsi zero, mstatus, 0x8 + + # Set up UART + lui t1, 0x10000 + li a0, 0x80 # DLAB=1 + sb a0, 3(t1) + li a0, 1 # Full speed + sw a0, 0(t1) + li a0, 0x03 # 8N1, DLAB=0 + sb a0, 3(t1) + + # Run test for around 60s + call rtc_get + li t0, 30 + slli t0, t0, 30 # Approx. 10e9 ns + add t0, t0, a0 +0: + # Tight loop with memory accesses + li a1, 1000000 + la a2, semiargs +1: + ld a0, 0(a2) + sd a0, 0(a2) + addi a1, a1, -1 + bnez a1, 1b + + li a0, '.' + call send_byte + call rtc_get + bltu a0, t0, 0b + + li a0, '\n' + call send_byte + + # Exit + li a0, 0 + lla a1, semiargs + li t0, 0x20026 # ADP_Stopped_ApplicationExit + sd t0, 0(a1) + sd a0, 8(a1) + li a0, 0x20 # TARGET_SYS_EXIT_EXTENDED + + # Semihosting call sequence + .balign 16 + slli zero, zero, 0x1f + ebreak + srai zero, zero, 0x7 + + j . + +rtc_get: + # Get current time from the goldfish RTC + lui t3, 0x0101 + lw a0, 0(t3) + lw t3, 4(t3) + slli t3, t3, 32 + add a0, a0, t3 + ret + +send_byte: + # Send a single byte over the serial + lui t3, 0x10000 + lb a1, 5(t3) + andi a1, a1, 0x20 + beqz a1, send_byte + sb a0, 0(t3) + ret + + .balign 4 +trap: + lui t5, 0x0200c + ld t6, -0x8(t5) # MTIME + addi t6, t6, 100 + lui t5, 0x02004 + sd t6, 0(t5) # MTIMECMP + mret + + .data + .balign 16 +semiargs: + .space 16 -- 2.47.3