* [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner
@ 2025-10-27 5:37 Akihiko Odaki
2025-10-27 9:39 ` Philippe Mathieu-Daudé
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Akihiko Odaki @ 2025-10-27 5:37 UTC (permalink / raw)
To: qemu-devel
Cc: Palmer Dabbelt, Alistair Francis, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, qemu-riscv, Akihiko Odaki
as points to the MemoryRegion itself. s is the device that owns the
MemoryRegion.
Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
---
hw/riscv/riscv-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c
index b33c7fe3259e..51c28d4f8c57 100644
--- a/hw/riscv/riscv-iommu.c
+++ b/hw/riscv/riscv-iommu.c
@@ -1362,7 +1362,7 @@ static AddressSpace *riscv_iommu_space(RISCVIOMMUState *s, uint32_t devid)
/* IOVA address space, untranslated addresses */
memory_region_init_iommu(&as->iova_mr, sizeof(as->iova_mr),
TYPE_RISCV_IOMMU_MEMORY_REGION,
- OBJECT(as), "riscv_iommu", UINT64_MAX);
+ OBJECT(s), "riscv_iommu", UINT64_MAX);
address_space_init(&as->iova_as, MEMORY_REGION(&as->iova_mr), name);
QLIST_INSERT_HEAD(&s->spaces, as, list);
---
base-commit: 36076d24f04ea9dc3357c0fbe7bb14917375819c
change-id: 20251027-iommu-94d68e7a85d2
Best regards,
--
Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner
2025-10-27 5:37 [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner Akihiko Odaki
@ 2025-10-27 9:39 ` Philippe Mathieu-Daudé
2025-10-27 13:21 ` Daniel Henrique Barboza
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-10-27 9:39 UTC (permalink / raw)
To: Akihiko Odaki, qemu-devel
Cc: Palmer Dabbelt, Alistair Francis, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, qemu-riscv
On 27/10/25 06:37, Akihiko Odaki wrote:
> as points to the MemoryRegion itself. s is the device that owns the
> MemoryRegion.
>
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> ---
> hw/riscv/riscv-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner
2025-10-27 5:37 [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner Akihiko Odaki
2025-10-27 9:39 ` Philippe Mathieu-Daudé
@ 2025-10-27 13:21 ` Daniel Henrique Barboza
2025-10-28 4:04 ` Nutty.Liu
2025-10-31 3:58 ` Alistair Francis
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Henrique Barboza @ 2025-10-27 13:21 UTC (permalink / raw)
To: Akihiko Odaki, qemu-devel
Cc: Palmer Dabbelt, Alistair Francis, Weiwei Li, Liu Zhiwei,
qemu-riscv
On 10/27/25 2:37 AM, Akihiko Odaki wrote:
> as points to the MemoryRegion itself. s is the device that owns the
> MemoryRegion.
>
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> ---
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> hw/riscv/riscv-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c
> index b33c7fe3259e..51c28d4f8c57 100644
> --- a/hw/riscv/riscv-iommu.c
> +++ b/hw/riscv/riscv-iommu.c
> @@ -1362,7 +1362,7 @@ static AddressSpace *riscv_iommu_space(RISCVIOMMUState *s, uint32_t devid)
> /* IOVA address space, untranslated addresses */
> memory_region_init_iommu(&as->iova_mr, sizeof(as->iova_mr),
> TYPE_RISCV_IOMMU_MEMORY_REGION,
> - OBJECT(as), "riscv_iommu", UINT64_MAX);
> + OBJECT(s), "riscv_iommu", UINT64_MAX);
> address_space_init(&as->iova_as, MEMORY_REGION(&as->iova_mr), name);
>
> QLIST_INSERT_HEAD(&s->spaces, as, list);
>
> ---
> base-commit: 36076d24f04ea9dc3357c0fbe7bb14917375819c
> change-id: 20251027-iommu-94d68e7a85d2
>
> Best regards,
> --
> Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner
2025-10-27 5:37 [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner Akihiko Odaki
2025-10-27 9:39 ` Philippe Mathieu-Daudé
2025-10-27 13:21 ` Daniel Henrique Barboza
@ 2025-10-28 4:04 ` Nutty.Liu
2025-10-31 3:58 ` Alistair Francis
3 siblings, 0 replies; 5+ messages in thread
From: Nutty.Liu @ 2025-10-28 4:04 UTC (permalink / raw)
To: Akihiko Odaki, qemu-devel
Cc: Palmer Dabbelt, Alistair Francis, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, qemu-riscv
On 10/27/2025 1:37 PM, Akihiko Odaki wrote:
> as points to the MemoryRegion itself. s is the device that owns the
> MemoryRegion.
>
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> ---
> hw/riscv/riscv-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Nutty Liu <nutty.liu@hotmail.com>
Thanks,
Nutty
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner
2025-10-27 5:37 [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner Akihiko Odaki
` (2 preceding siblings ...)
2025-10-28 4:04 ` Nutty.Liu
@ 2025-10-31 3:58 ` Alistair Francis
3 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2025-10-31 3:58 UTC (permalink / raw)
To: Akihiko Odaki
Cc: qemu-devel, Palmer Dabbelt, Alistair Francis, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, qemu-riscv
On Mon, Oct 27, 2025 at 3:39 PM Akihiko Odaki
<odaki@rsg.ci.i.u-tokyo.ac.jp> wrote:
>
> as points to the MemoryRegion itself. s is the device that owns the
> MemoryRegion.
>
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> hw/riscv/riscv-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c
> index b33c7fe3259e..51c28d4f8c57 100644
> --- a/hw/riscv/riscv-iommu.c
> +++ b/hw/riscv/riscv-iommu.c
> @@ -1362,7 +1362,7 @@ static AddressSpace *riscv_iommu_space(RISCVIOMMUState *s, uint32_t devid)
> /* IOVA address space, untranslated addresses */
> memory_region_init_iommu(&as->iova_mr, sizeof(as->iova_mr),
> TYPE_RISCV_IOMMU_MEMORY_REGION,
> - OBJECT(as), "riscv_iommu", UINT64_MAX);
> + OBJECT(s), "riscv_iommu", UINT64_MAX);
> address_space_init(&as->iova_as, MEMORY_REGION(&as->iova_mr), name);
>
> QLIST_INSERT_HEAD(&s->spaces, as, list);
>
> ---
> base-commit: 36076d24f04ea9dc3357c0fbe7bb14917375819c
> change-id: 20251027-iommu-94d68e7a85d2
>
> Best regards,
> --
> Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-31 3:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-27 5:37 [PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner Akihiko Odaki
2025-10-27 9:39 ` Philippe Mathieu-Daudé
2025-10-27 13:21 ` Daniel Henrique Barboza
2025-10-28 4:04 ` Nutty.Liu
2025-10-31 3:58 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).