From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org,
Lucas Mateus Castro <lucas.araujo@eldorado.org.br>,
Gan Qixin <ganqixin@huawei.com>
Cc: qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org,
qemu-block@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2 2/4] bulk: Coding style fixes
Date: Wed, 18 Jan 2023 18:04:12 +0100 [thread overview]
Message-ID: <5f6c99eb-fca8-2270-fa4d-758e548b05b1@linaro.org> (raw)
In-Reply-To: <fd06e139-c6e8-e978-c0ed-3e9aca258f19@redhat.com>
On 18/1/23 17:09, Thomas Huth wrote:
> On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote:
>> Fix the following checkpatch.pl violation on lines using the
>> TARGET_FMT_plx definition to avoid:
>>
>> WARNING: line over 80 characters
>
> It's just a warning...
>
>> @@ -420,8 +421,9 @@ static int get_segment_6xx_tlb(CPUPPCState *env,
>> mmu_ctx_t *ctx,
>> hwaddr curaddr;
>> uint32_t a0, a1, a2, a3;
>> - qemu_log("Page table: " TARGET_FMT_plx " len "
>> TARGET_FMT_plx
>> - "\n", ppc_hash32_hpt_base(cpu),
>> + qemu_log("Page table: " TARGET_FMT_plx
>> + " len " TARGET_FMT_plx "\n",
>> + ppc_hash32_hpt_base(cpu),
>> ppc_hash32_hpt_mask(cpu) + 0x80);
>> for (curaddr = ppc_hash32_hpt_base(cpu);
>> curaddr < (ppc_hash32_hpt_base(cpu)
>
> ... and in cases like this, I'd really prefer the original line.
>
> I think it would be better to just fix it if checkpatch.pl really throws
> an ERROR instead of a WARNING.
See this thread and its references ¯\_(ツ)_/¯
https://lore.kernel.org/qemu-devel/CAFEAcA-yMZjJW=AJm=XLbrub1D-8iX0OKE78V_TzQmfC2RdXyw@mail.gmail.com/
next prev parent reply other threads:[~2023-01-18 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 8:39 [PATCH v2 0/4] bulk: Replace TARGET_FMT_plx by HWADDR_PRIx Philippe Mathieu-Daudé
2023-01-11 8:39 ` [PATCH v2 1/4] hw: Remove hardcoded tabs (code style) Philippe Mathieu-Daudé
2023-01-11 19:48 ` Richard Henderson
2023-01-11 8:39 ` [PATCH v2 2/4] bulk: Coding style fixes Philippe Mathieu-Daudé
2023-01-11 19:48 ` Richard Henderson
2023-01-18 16:09 ` Thomas Huth
2023-01-18 17:04 ` Philippe Mathieu-Daudé [this message]
2023-01-11 8:39 ` [PATCH v2 3/4] bulk: Replace TARGET_FMT_plx -> HWADDR_PRIx Philippe Mathieu-Daudé
2023-01-11 19:50 ` Richard Henderson
2023-01-11 8:39 ` [RFC PATCH v2 4/4] bulk: Prefix '0x' to hex values displayed with HWADDR_PRIx format Philippe Mathieu-Daudé
2023-01-20 7:24 ` [PATCH v2 0/4] bulk: Replace TARGET_FMT_plx by HWADDR_PRIx Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f6c99eb-fca8-2270-fa4d-758e548b05b1@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ganqixin@huawei.com \
--cc=lucas.araujo@eldorado.org.br \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).