From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56DB0CCD1BF for ; Fri, 24 Oct 2025 21:00:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vCOtZ-0007kW-9X; Fri, 24 Oct 2025 17:00:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCOtY-0007kG-98 for qemu-riscv@nongnu.org; Fri, 24 Oct 2025 17:00:20 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vCOtW-0005g8-HX for qemu-riscv@nongnu.org; Fri, 24 Oct 2025 17:00:20 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-47103b6058fso18542255e9.1 for ; Fri, 24 Oct 2025 14:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761339616; x=1761944416; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XcIxaQ67a8jVVOfKmnTa9SFKmogMi3dQET10JvoF3/M=; b=EUgdgC1JhQPN4MuiS8vlrk6dQFtAsXhUUPqda+3cdIjk17t12R5f2Br8i8ZXnqqei+ gMqfveGwFOH8xRvtOG089QCGQ/Uay37/5g10mgVTKBCmoH1bQKHmZr2OCGoo8/H5lfr2 fkLIsF3xUygb08hg02Q8nz+MKiL4CyXjQi8JKQQYR/mUVDMpUkdIbsgZHKERTT4t8x8H mVLE9UlC14UmpM2QkYnv8bukeV4q5YtRH0ZFgWi34kUBuX0OjREC8gSEEcMnseu8K+PB tkY1CNl/xjPMGOikRRQcCgTQGf8AeSctYJ0kJ0mpUeXrqeU/YoLTerLNrfyJIoPoHl2Y a1LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761339616; x=1761944416; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XcIxaQ67a8jVVOfKmnTa9SFKmogMi3dQET10JvoF3/M=; b=K/U+7X7pItrcdEIECVI4wdO4xk1jjcrcGIXnSI4v/1ynlvFavNzdhv13GXZ9sUzplN uj+DUQcRnJv9JKcyUc//BQDtiqX+yiLoabX6kp1l8qdd4ttPQmB2X+SUr4s68uCypoi3 QHd3UlZ4gx67FaCyjabQgDolN9hEXtMVfiy8fqLjFbKzP4XVMGDyBIxksw2OQ84lIWX2 S15ifE43QofXex0loSvxivelvoWvQFjCwR9umUDnYV3uQmN5bPxpmfaYoarQZxoNnLJD XuOja9gtegOtxLaBDS8rfTtEeI1OqDYfLhv/F45kJr7D7ReJVa7smAaTmDZRGV0zmgLM kD6g== X-Forwarded-Encrypted: i=1; AJvYcCUD09xsFEDf9pyeVIEqHG/fuf5tWuIwVWKbdz+UQnBdj7W9n6rgNUjIi3YTTtON8C3Hg+carmEcD4kF@nongnu.org X-Gm-Message-State: AOJu0YwdARMW0izIOggeB1OsmY/fb5Ziiu0mhWDtljTDsZrV8mXyOn/k 2jQ3teNUQ7FgZc3IQXTaHp/Z+/PRAlpINMzAp9aRfB7KZ5rWn6JCQq4pILXWO7O0BXc= X-Gm-Gg: ASbGncu1d094XQbrdXTmMe+TNPbAfZRsacOEdDfYM+nNvSWCbuUl1LRGLCBDxB1aZvJ p3dkyMssEWAZVK72a0LDuEpe8tRnPR0TUQFbx4PZzbGkKhEVlCejS/OCRsvHJYnzJykHiJJiLqi nYU/bkYcxChwue0ma9L/2EfuMmGCkJDtuUXJ/rqVijVgCPQga8wpZK4y1gmmblFcKdCQ8ESo0D/ avaOGTdt3QG8sw4uecHG9UXTuw84ds5q2AK4iykewKv4TW6LUvAkH4HoIz/uLY6OGcIIzIN+rTj +b6b5iALwDLm2KRW2j2spezixQcCF7cTb6aAI46ItqviH4ZdvvMjKP4JTufo//X9h/AhVp8pBBN hqF7vZdA6TzHzQrvc8rH468qgNdwBRiy/r2/Gg79bRGNXycXbnvwt8H5ixT1QKBzczJ6fL6g79y usSm4hFKzKZznvDiJxSN3crvN7+J9cJavk7z0qFQTlE6g8V083PWffOQ== X-Google-Smtp-Source: AGHT+IH3C5fpFaNOpwEIrGKdP2Ewlswyv/5J1kKxz9xjLgB9bCb5iiYTPpa8ND6AlvQNTLgxF4fyFQ== X-Received: by 2002:a05:600c:3495:b0:46d:1a9b:6d35 with SMTP id 5b1f17b1804b1-475d242c75cmr35087015e9.14.1761339616380; Fri, 24 Oct 2025 14:00:16 -0700 (PDT) Received: from [192.168.69.201] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dd374e41sm1195045e9.12.2025.10.24.14.00.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Oct 2025 14:00:15 -0700 (PDT) Message-ID: <7f0180ec-c08e-48dd-8b46-fc70ffbbe49f@linaro.org> Date: Fri, 24 Oct 2025 23:00:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/27] hw/sysbus: Use memory_region_name() Content-Language: en-US To: Mark Cave-Ayland , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org, Paolo Bonzini , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost References: <20251024190416.8803-1-philmd@linaro.org> <20251024190416.8803-4-philmd@linaro.org> <1201fe45-f822-4e1e-8cd7-84b23eaa2bd0@ilande.co.uk> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <1201fe45-f822-4e1e-8cd7-84b23eaa2bd0@ilande.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 24/10/25 21:40, Mark Cave-Ayland wrote: > On 24/10/2025 20:03, Philippe Mathieu-Daudé wrote: > >> MemoryRegion::name is kind of internal. Use the proper >> memory_region_name() accessor, which might return a different >> name. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   hw/core/sysbus.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c >> index ae447c1196a..d33be6b2b52 100644 >> --- a/hw/core/sysbus.c >> +++ b/hw/core/sysbus.c >> @@ -154,7 +154,7 @@ void sysbus_mmio_map(SysBusDevice *dev, int n, >> hwaddr addr) >>   int sysbus_mmio_map_name(SysBusDevice *dev, const char *name, hwaddr >> addr) >>   { >>       for (int i = 0; i < dev->num_mmio; i++) { >> -        if (!strcmp(dev->mmio[i].memory->name, name)) { >> +        if (!strcmp(memory_region_name(dev->mmio[i].memory), name)) { >>               sysbus_mmio_map(dev, i, addr); >>               return i; >>           } > > Interesting. I'm mildly curious as to if you discovered anything that > broke with this change (even though I agree it is correct)? I'm working on having qdev to absorb sysbus features (MMIO, PIO and IRQ links); what is left is the qom parenting on the main sysbus, only used during legacy reset; I hope to convert the remaining as a cripple reset tree.